Blend the radius searched for stars based on desired density.#5116
Merged
sturnclaw merged 2 commits intopioneerspacesim:masterfrom Jan 13, 2021
Merged
Blend the radius searched for stars based on desired density.#5116sturnclaw merged 2 commits intopioneerspacesim:masterfrom
sturnclaw merged 2 commits intopioneerspacesim:masterfrom
Conversation
…e desired radius depending on the star density
Contributor
Author
|
Also @Web-eWorks I keep being really impressed by how good the Ctrl+i debug/performance display is! |
Member
|
If one sets to 0 background stars, will one still get the "real" stars then? |
Contributor
Author
|
The minimum was set to 50,000 stars, so it'll work like this:
I suppose that the min/max range could now be changed to 0.0 instead of 0.01 |
… now that I'm lerping between min and max values
Contributor
Author
|
@impaktor and now I've changed the lerp/mix range to 0.0 to 1.0 👍 |
sturnclaw
approved these changes
Jan 13, 2021
Member
sturnclaw
left a comment
There was a problem hiding this comment.
Looks nice and clean as always! Haven't had a chance to test it, but it's minimal enough I don't think there will be any bugs to find.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Limit the radius searched for stars and mix it from the minimum to the desired radius depending on the star density.
Fixes #4990