Merged
Conversation
sturnclaw
force-pushed
the
microfixes
branch
from
bf36937 to
4eb1f68
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5040:
ui.getColumnWidth()appears to be ignoring some window padding, which was causing incorrect behavior. Now we query forui.getContentRegion().xwhich isn't quite correct either but works without unduly wrapping at all sizes.Fixes #4981: this was a simple matter where we weren't updating the camera's position when the controller didn't have input focus. I also added a bit of code that should help to prevent the cursor from getting stuck in hidden mode.
Fixes #5065: dead simple, just needed to tell Pioneer to save the binding when changing the checkbox.
Fixes #5055: this was broken for several reasons - the tooltip was being used as the button ID, so clicking on any of the buttons wasn't switching the view correctly. I took the chance to simplify the logic a bit.
Fixes #5046: also simple, just needed the escape key to trigger the chat form closing. Implemented a small helper to add a priority system to the escape key so it closes one item at a time and doesn't go from the chat form all the way to the options window in one press.