Fix ambient music looping#5061
Merged
sturnclaw merged 1 commit intopioneerspacesim:masterfrom Dec 11, 2020
WKFO:loop
Merged
Conversation
Member
|
@WKFO the relevant code is in bool repeat = true;
if (lua_isboolean(l, 2))
repeat = lua_toboolean(l, 2) != 0;Which should instead be |
Contributor
Author
|
@Web-eWorks saves me again. Thank you, and I pushed the change. |
sturnclaw
requested changes
Dec 10, 2020
sturnclaw
approved these changes
Dec 10, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I haven't got the slightest idea why no argument to loop isn't treated as such, but adding a default seems to fix #5049
It looks like otherwise the related code in SoundMusic.cpp gets a repeat = true (line 53 I think).
¯_(ツ)_/¯