X Tutup
Skip to content

Port Missions Display to PiGui#5025

Merged
sturnclaw merged 5 commits intopioneerspacesim:masterfrom
sturnclaw:remove-ui-view
Nov 26, 2020
Merged

Port Missions Display to PiGui#5025
sturnclaw merged 5 commits intopioneerspacesim:masterfrom
sturnclaw:remove-ui-view

Conversation

@sturnclaw
Copy link
Member

@vakhoir if you're out there you can come back now, the worst is over! I took heed and decided not to redesign the missions display while porting it; this drastically reduced the workload involved. I'd say it took me 6-8 hours to do this, all told.

Some before/after screenshots to show off:
image
image
Not strictly a "before", but funny nonetheless

After:
image
image
image

Need to fix up the translation strings (why is GO_BACK in five different module resources and not ui-core?!) and maybe look into right-aligned wrapped text, but otherwise it's good to go, and that's pretty much everything we had in newUI dead and gone.

- Six extra translations of 'ly', one for each mission module
- Added GO_BACK and SET_RETURN_ROUTE to ui-core (as they're pretty standard for misions)
@impaktor
Copy link
Member

impaktor commented Nov 26, 2020

Sweet! If this is the last of NewUI, I'd imagine there would be a lot on C++ side that could be removed? Basically the NewUI bindings into lua?

EDIT Btw, I liked the use of colours in the crew roster tab, I know if one could use it here as well, e.g. status "active" is green, and maybe "days left: xx" also has some stand out colour? I know, we shouldn't expand the scope of this, just throwing it out there.

@sturnclaw
Copy link
Member Author

Btw, I liked the use of colours in the crew roster tab, I know if one could use it here as well, e.g. status "active" is green, and maybe "days left: xx" also has some stand out colour? I know, we shouldn't expand the scope of this, just throwing it out there.

@impaktor I know; I wanted to keep this PR simple, and while I could have hacked colors into the display I think there are better ways to do it. I'll revisit it when I implement right-aligned wrapped text.

@sturnclaw sturnclaw merged commit 4f2e3ad into pioneerspacesim:master Nov 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

X Tutup