X Tutup
Skip to content

Decreasing the max star size to 0.3#4991

Merged
sturnclaw merged 1 commit intopioneerspacesim:masterfrom
bszlrd:bigstarsmaller
Nov 3, 2020
Merged

Decreasing the max star size to 0.3#4991
sturnclaw merged 1 commit intopioneerspacesim:masterfrom
bszlrd:bigstarsmaller

Conversation

@bszlrd
Copy link
Contributor

@bszlrd bszlrd commented Oct 31, 2020

I think the bigger star size on the starfield is too excessive, it clashes with the HUD, and isn't really feel like they are brighter stars.
So I've decreased the brightnessApparentSizeFactor from 0.5 to 0.3
(Enlarge the screenshots to see the effect properly:
I think they look much better at 03. They are more subtle, but in a nice way:
0 3

Original 0.5:
0 5

At 0.4 they are still a bit too much in my opinion
0 4

At 0.1, they aren't visible most of the time:
0 1

And as a bonus, at 2.0, we turn Olbers' paradox on it's head:
2 0

Copy link
Member

@sturnclaw sturnclaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, with the eventual intention to dynamically adjust star brightness based on exposure / atmosphere scattering.

@ConfedMajor
Copy link

@Web-eWorks Don't forget star colors, they can create beautiful effects!
RobloxScreenShot20201031_230847024
Also don't forget nebulaes!
RobloxScreenShot20201031_231104940

@WKFO
Copy link
Contributor

WKFO commented Nov 1, 2020

I say no to nebulae unless they are actually in the game. The Magellanic Clouds might be cool though.
Correct me if I'm wrong, AFAIK Pioneer generates sectors according to some star density map, is there a possibility that we can use that data to set ambient lighting or make it affect overall brightness according to where in the galaxy you are?

@Gliese852
Copy link
Contributor

I am also against beauties, but other galaxies can be drawn, they are unattainable in the game anyway.

@bszlrd
Copy link
Contributor Author

bszlrd commented Nov 1, 2020

I agree that there should be no such nebulae, unless we actually have them and they are visitable. Especially because most of them, and galaxies for that matter are rahter small on the sky.

@ConfedMajor
Copy link

no such nebulae, unless we actually have them and they are visitable

@nozmajner Uh... Hyperspace clouds? 😅

@sturnclaw sturnclaw merged commit 5091990 into pioneerspacesim:master Nov 3, 2020
@bszlrd
Copy link
Contributor Author

bszlrd commented Nov 3, 2020

Hmm, those could sure benefit from a facelift. But there's no way currently to do anything about them without going knee-deep in the code as far as I know.

@fluffyfreak
Copy link
Contributor

Hmm, those could sure benefit from a facelift. But there's no way currently to do anything about them without going knee-deep in the code as far as I know.

If you wanted to change them then do some mockups, or even buildup a model preferrably involving simple geometry and textures. We could put something together without having to write full-screen, post-processed, ray-marched stuff ;)

@bszlrd
Copy link
Contributor Author

bszlrd commented Nov 3, 2020

I'm not yet sure how I'd approach the looks of it though. I'll think about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

X Tutup