Improved station traffic control communications by WKFO · Pull Request #4987 · pioneerspacesim/pioneer

WKFO · 2020-10-27T16:44:20Z

Calm down, I just came back with a fresh repository.

When player requests launch, actually talk to them
Give a heads up for traffic during departure
Give a heads up for traffic during approach
If a ground station, provide local gravity and atmosphere information
Give a heads up upon entering and exiting the family friendly "no weapons, no trash dumping" airspace
Display local gravity and pressure on station lobby

WKFO · 2020-10-28T15:06:03Z

Would we also want to be able to ask ground stations for the local gravity and atmospheric pressure readings without requesting landing? I don't know how I would code that yet, but wanted to ask anyway.

Gliese852 · 2020-10-28T16:25:58Z

@WKFO imho this data can be viewed in the database, is it worth bothering the dispatcher?

WKFO · 2020-10-28T17:05:58Z

Real airports provide pressure data for planes to calibrate their altimeters, as well as wind/gust data on runway approach. We don't have such things of course, but I wanted to give Pioneer a similar flight sim-y feeling. I see it as more of a world building element rather than gameplay. (So if databases are not available/faulty for some reason and ship instruments are wrong, the station readings will be what you trust)

This was my reasoning, and I don't know if it is worth it or not, this is why I'm asking you guys :)

The-EG · 2020-10-29T11:22:30Z

Real airports provide pressure data for planes to calibrate their altimeters, as well as wind/gust data on runway approach. We don't have such things of course, but I wanted to give Pioneer a similar flight sim-y feeling. I see it as more of a world building element rather than gameplay. (So if databases are not available/faulty for some reason and ship instruments are wrong, the station readings will be what you trust)

This was my reasoning, and I don't know if it is worth it or not, this is why I'm asking you guys :)

My first thought when I saw this was the flight sims I used to play, and I love the idea.

I think it's also a chance to introduce some flavor too, if that's something of interest. I can't remember which flight sim it was, but one would do some interesting things like:
If you wandered off the taxi ways while taxing to/from a runway, ground control would thank you for mowing the grass and then politely ask you to use the taxiways in the future.
If you flew into the airport airspace without permission it would announce/broadcast a warning to all aircraft of your presence.

I think things like that, and what you are doing here go a long way to feeling like you're interacting with someone at a station rather than landing at a completely automated facility.

data/lang/core/en.json

impaktor

Looks good, I've made som suggestions, not required changes.

impaktor · 2020-11-04T07:40:55Z

data/lang/core/en.json

  },
+  "WATCH_FOR_TRAFFIC_ON_APPROACH": {
+    "description": "",
+    "message": "Please watch for traffic on your approach."


native speakers: is "look out for" better than "watch for"? Both OK?

EDIT:

<sturnclaw> "please be aware of traffic" if you want to be stuffy, "please watch for traffic" if you want to sound semi-formal. I doubt ATC would be saying "please look for traffic", as it's not directive enough. [08:48] <sturnclaw> "watch" somewhat implies "keep a watch for" traffic as in avoidance, whereas "look" can be interpreted to mean "go find traffic" with the intent to crash into it :D

"Please mind the traffic on your approach"?

data/lang/module-crimetracking/en.json

impaktor · 2020-11-04T08:00:44Z

data/lang/ui-core/en.json

+  },
+  "LAUNCH_PERMISSION_GRANTED_DEPART_QUICK": {
+    "description": "",
+    "message": "Permission granted. Please do not clutter the landing area and depart quickly."


Maybe "please do not loiter ..." is more apt, than "clutter"?

Actually, looking at the code, this is for when the station is under heavy load, which is a nice touch, but maybe it should be crammed in there as well, like "We're close to maximum traffic (docking?) capacity, please do not clutter/loiter ...."

Actually, perhaps "landing area" should be "docking (area?)", which might work better with both planet side and orbital stations? Does one dock with ground stations? Maybe just nitpicking...

I had the same "docking"/"landing" dilemma here, and space stations have pads instead of docking ports, so I went with "landing".

impaktor · 2020-11-04T08:08:12Z

src/SpaceStation.cpp

+					outMsg += " " + stringf(Lang::STATION_GRAV, formatarg("grav", gravity, "f.2"));
+				}
+			}
+			if (GetNearbyTraffic(50000) > 0) { //50km


The nearby traffic variable in lua side is 20km, and here 50km? Ignore this comment if this is correct, I'm not doing a detailed reading of the code.

I don't quite remember if I did that 20km on purpose... They should probably be equal.

Is it possible to share the variable, so it's imported across c++/lua side? Or maybe that's overkill?

It looks like that requires some brain effort, so I'm not figuring it out today. I just changed the value to 50km for now.

The orbital SOI is 20km, maybe that's why?

WKFO · 2020-11-04T12:53:21Z

I have quite some informal-ish strings ready to be included into the station comms, but they stand out a bit too much among the generic random messages and I would rather have them when we have a way to classify the formality/cheesiness of a space station traffic controller via factions and/or lawlessness (or maybe even put some of them as easter eggs). I'm not going to implement it in this PR or probably any time soon, but just as a note, I'm leaving this comment here.

sturnclaw · 2020-11-05T17:20:05Z

src/SpaceStation.cpp

 			sd.maxOffset = std::max((pPort->maxShipSize / 2 - bboxRad), float(pPort->maxShipSize / 5.0));
 			sd.maxOffset *= sd.maxOffset;
 			outMsg = stringf(Lang::CLEARANCE_GRANTED_BAY_N, formatarg("bay", i + 1));
+			if (this->IsGroundStation()) {


I would prefer that this logic be moved into Lua and triggered with an onDockingClearanceGranted / onDockingClearanceDenied event. This reduces code duplication and moves the code that's merely concerned with pretty-printing the UI away from the code that's responsible for determining whether docking is even possible.

Okay, I'll see what I can do.

sturnclaw

I went ahead and refactored the way we handle docking clearance messages to move it to Lua; looking back, it was a bit harder of a task than I originally envisioned.

Feel free to give it a look over and let me know if I messed anything up. At this point, I like where this PR is at and I'm good to merge it in when you are.

WKFO · 2020-11-12T10:40:39Z

A quick playtest shows that when requesting docking clearance, the Comms.Message output shows ship's atmospheric pressure instead of the station's. I don't get why though, the code looked good to me.

(Should say "...pressure is 0.80 atm")

Also the gravity value shown is in m/s^2, not g. We need to divide it by 9.80665 (or rounded-up 9.81) to get it in unit g.

sturnclaw · 2020-11-12T16:37:36Z

Yep, I totally missed dividing gravity, my bad. I'll take a look at the pressure issue; I'm not sure what's going on there either.

sturnclaw · 2020-11-12T17:59:48Z

I'm using the exact same method call that you are to display pressure when docked; I'm not sure what's going on there. For now, I'll say that this PR is good to merge (once conflicts are cleared up), and we'll adjust that behavior going forward.

…uest

- Expose a few SpaceStation methods to Lua - Refactor LuaEvent to support pushing zero to three args to Lua

- Remove some strings from core/ - Add formatters for Gravity(g) and Pressure(atm)

impaktor reviewed Oct 30, 2020

View reviewed changes

data/lang/core/en.json Outdated Show resolved Hide resolved

WKFO marked this pull request as ready for review November 1, 2020 12:05

impaktor reviewed Nov 4, 2020

View reviewed changes

sturnclaw requested changes Nov 5, 2020

View reviewed changes

sturnclaw approved these changes Nov 11, 2020

View reviewed changes

WKFO and others added 15 commits November 12, 2020 12:59

Station comms on launch request

c691204

Ground stations provide local grav and atmo press info on landing req…

e30f2cb

…uest

Convert m/s^2 to g for easy comparison

86a8bb7

Round up local gravity and pressure values to display

f53107d

Warn about traffic on station approach

766dfe5

Modular station approach messages

d21ceba

Show local gravity and atmosphere on ground station lobby

f5ddecb

Talk to player on entering and exiting station controlled space

24a5a65

Reduce lawEnforcedRange to 50km

65e69d8

Fix traffic control bugs

0ae787e

Cleanup station comms

5114b31

Move traffic control to its own module

0933a9e

Refactor docking clearance API

a85c709

- Expose a few SpaceStation methods to Lua - Refactor LuaEvent to support pushing zero to three args to Lua

Handle station docking log messages in Lua

fa230d4

- Remove some strings from core/ - Add formatters for Gravity(g) and Pressure(atm)

Display earth gravities, not m/s/s

5ad4bcd

sturnclaw merged commit 46fa423 into pioneerspacesim:master Nov 12, 2020

WKFO deleted the stationatc branch December 2, 2020 18:10

Uh oh!

Conversation

WKFO commented Oct 27, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

WKFO commented Oct 28, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Gliese852 commented Oct 28, 2020

Uh oh!

WKFO commented Oct 28, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

The-EG commented Oct 29, 2020

Uh oh!

Uh oh!

impaktor left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

impaktor Nov 4, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

WKFO commented Nov 4, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sturnclaw left a comment

Choose a reason for hiding this comment

Uh oh!

WKFO commented Nov 12, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sturnclaw commented Nov 12, 2020

Uh oh!

sturnclaw commented Nov 12, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

WKFO commented Oct 27, 2020 •

edited

Loading

WKFO commented Oct 28, 2020 •

edited

Loading

WKFO commented Oct 28, 2020 •

edited

Loading

impaktor Nov 4, 2020 •

edited

Loading

WKFO commented Nov 12, 2020 •

edited

Loading