Move Economy & Trade -view to pigui#4967
Conversation
|
I have no strong opinions on progress gauges, but cash should be shown. Isn't it the only place where we can see cash in-flight? |
|
As a straight conversion of what's there, this is good. But, I feel like there's a struggle to find a way to fill up the more of the screen on some of these windows (not just this one). Do they really need to be dedicated full screen displays? As far as gauges or not go: I'd approach it like any data analysis visualization. Why am I opening this screen in the first place, and when I do what's the question(s) I'm trying to answer? For an example:
Going through that, I'd argue that the 'pump down,' 'refuel,' fuel and hyperjump fuel info/gauges are all related and could actually be grouped visually. I think a grouping like that would also help make the interface more intuitive as well. If we want gauges, having the fuel gauge where the current fuel info is (above the pump down, refuel buttons) and the hyperjump fuel gauge below the buttons could give a nice visual que of what's going on. |
|
Thanks for the font! What if you also show the fuel use rate? |
|
I don't think fuel use rate is much useful. Knowing how much time you need to burn up your fuel isn't that important information compared to deltaV. |
|
@nozmajner deltaV depends on the load of the ship, while this value is constant for the ship, and characterizes the efficiency of the engines, if I understood it correctly. Besides, it seems to me it will add a sense of scale. |
|
For that Exhaust velocity or ISP is a more standard measure in space flight. Admittedly not that intuitive though. |
|
@nozmajner since use rate = 0.00282 ton/sec, I guess -> 1.015 ton/hour get it from: pioneer/src/ship/Propulsion.cpp Line 195 in d5e6979 EDITED 2 times, sorry |
|
@nozmajner deltaV does not take into account the fact that you can carry additional fuel in the hold |
ba7988a to
43e1e27
Compare
a99c60d to
df7f3de
Compare
43d49f9 to
085c7bd
Compare
4c028de to
d7b44d4
Compare
|
@impaktor I'm sorry, I just couldn't help myself 😛 Also made the TabView debug reloading interface simpler and fixed a bug with the ImGui stack cleanup handler that wasn't cleaning up fully and was causing C++ assertions when a script errored out. Feel free to squash my commits as needed. |
- Removed double padding from window - Reload the ship cargo list when it changes, not every frame - Made the cargo gauge display the cargo capacity, not the equipment space
- Fixed a bug in ImGuiStack cleanup - Simpler mechanism for registering reloaded views - Call refresh() on reloaded tabs to fix bugs
|
@Web-eWorks thanks! I've squashed my temporary commit, and rebased & merged to master. |
|
Indeed you shall! |




Thoughts
Working with this, I think there's a lot of stuff that's overlapping with "ship info". I'd suggest "ship info" only show the static info on that ship's stats, and equipment, and this "economy & trade view" shows all the stuff about cargo, fuel, interna-tank mass, and range. Possibly, this could be outside the scope of this PR.
Also, I had a wrestling match against the colorselectbutton since, in my estimation, it makes no sense, in how it tints the button, but for now, it's some kind of deactivated when landed (one cannot jettison when landed). I got the feeling I was using the wrong function, since it's not doing what I want, which is what the name suggestes it's supposed to do. Theme-issues.
Bug exposed in master?
I remember playing with this in june/july, and finding some inconsistency in how we define "cargo space" relative internal fuel mass, but I'm not sure I notice what it was. I.e. (back then) I thought the "Used" cargo space displayed in the cargo gauge bar was wrong.
What remains
At the moment I'm not quite sure how to do the first two in this list: