X Tutup
Skip to content

Remove price reduction when selling commodities#4876

Merged
sturnclaw merged 1 commit intopioneerspacesim:masterfrom
WKFO:trade1
May 10, 2020
Merged

Remove price reduction when selling commodities#4876
sturnclaw merged 1 commit intopioneerspacesim:masterfrom
WKFO:trade1

Conversation

@WKFO
Copy link
Contributor

@WKFO WKFO commented May 8, 2020

Sorry for rapid and major changes to the PR.
We now get full money back when selling a commodity, as opposed to equipment.

fixes #4858

@WKFO WKFO changed the title Quick fix for trade-breaking #4858 Fix #4858 May 8, 2020
@impaktor impaktor changed the title Fix #4858 Remove price reduction when selling commodities May 8, 2020
@impaktor
Copy link
Member

impaktor commented May 8, 2020

@vakhoir thoughts?

@sturnclaw
Copy link
Member

Pending a major rework of the Equipment system, this looks pretty good to me. Ideally cargo and equipment are two separate things, but this is a (reasonably) good stopgap.

@sturnclaw
Copy link
Member

Merging this, @vakhoir can chime in when he's next around :D

@sturnclaw sturnclaw merged commit d1471c8 into pioneerspacesim:master May 10, 2020
@WKFO WKFO deleted the trade1 branch May 16, 2020 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sell price reduction kills commodity trading

3 participants

X Tutup