Commodity name clean-up#4875
Commodity name clean-up#4875sturnclaw merged 2 commits intopioneerspacesim:masterfrom WKFO:lang-change
Conversation
|
I'm not sold on the last modification. When I worked with the commodity prices, I discovered the "Hand weapons" - "small arms" discrepancy in the code (and Frontier), but after speaking to @fluffyfreak I/we decided it was best to keep it as it was. At least, that's how I remember it then. |
|
I'll side with Small Arms under one condition - if Battle Weapons are intended to be things like APCs and rocket launchers, machine guns, power armor, etc. then it makes sense to have the definition between small arms like pistols, carbines, knives, etc and the bigger, more prohibited stuff that's intended to be outfitting a PMC or rebellion. If "Battle Weapons" is the small stuff like pistols, plasma swords, etc. then why do we need hand weapons? Knives are easily understood to be consumer goods already, and I highly doubt that a system government blocking all form of firearms is going to let shipments of medieval poleaxes in (although that's its own pickle, as when firearms are Battle Weapons, there's almost nothing left for the Hand Weapons category...) |
|
In game description for battle weapons: In game description for hand weapons/small arms: I don't care if we call it hand weapons or small arms, I just don't get why a single commodity is called two different things in the first place. I think we should call it either small arms, or hand weapons; not the former in one place and the latter in another. "Hand weapons" is okay too. |
Radioactives are mostly useful and should be paid for.
Radioactive waste mostly isn't and... you get the idea.
(I think it has been that way before, maybe it changed during pigui conversion project, idk)
Commodity "hand weapons" are called "small arms" in market but "hand weapons" in system economy data (and, in turn, trading computer). I changed all into "small arms", as it is in the commodity market.