Conversation
|
Great feature, sometimes we should fetch the preview in case our server has no permission to get the image. |
|
Any further changes? |
|
Yeah, I have to work on it still. Probably will have a bit of time today/tomorrow. |
|
Expecting your great work! |
c41443a to
08ab1cd
Compare
Signed-off-by: Lapo Luchini <lapo@lapo.it>
08ab1cd to
4549bc4
Compare
|
I tried updating this code again, but there are CORS problems too unfortunately: These problems can be avoided in the browser plugin, but this needs a major change in cooperation between the bookmarklet (which alone cannot read images from cache) and the browser extension. |
Work in progress: this seems to work already, but it forces upload from browser and I'm not sure we want that in every case.
When it works, delegating the server to download can often be faster (I'm thinking people on ADSL with good download but bad upload).
Maybe we should first try "upload from URL" and only try local upload (automatically) as a second try?
What do you suggest?
Once completed this would close #66.