Tried to make clearOnSuspend work.#57
Open
ams-tschoening wants to merge 2 commits intophpvirtualbox:developfrom
Open
Tried to make clearOnSuspend work.#57ams-tschoening wants to merge 2 commits intophpvirtualbox:developfrom
ams-tschoening wants to merge 2 commits intophpvirtualbox:developfrom
Conversation
uqs
pushed a commit
to freebsd/freebsd-ports
that referenced
this pull request
Jul 27, 2017
Sadly upstream is very silent and has not released a new version which supports VirtualBox 5.1, supports PHP 7.1 or fixes bugs. In the meantime the community has created patches which are collected in the github projects bugtracker and pull requests. This unofficial version cherry picks the useful stuff of it. Highlights of unofficial phpvirtualbox 5.1-1: * based on git commit 65ebced (latest commit from May 19, 2016) * Patch to support Virtualbox 5.1 phpvirtualbox/phpvirtualbox#22 * Fix argument count mismatches revealed by PHP 7.1 phpvirtualbox/phpvirtualbox#24 * Make decryption of images/VMs work by not providing a password ID phpvirtualbox/phpvirtualbox#55 * Tried to make clearOnSuspend work phpvirtualbox/phpvirtualbox#57 PR: ports/220171 Submitted By: rozhuk.im With hat: vbox@ (kind of) git-svn-id: svn+ssh://svn.freebsd.org/ports/head@446746 35697150-7ecd-e111-bb59-0022644237b5
uqs
pushed a commit
to freebsd/freebsd-ports
that referenced
this pull request
Jul 27, 2017
Sadly upstream is very silent and has not released a new version which supports VirtualBox 5.1, supports PHP 7.1 or fixes bugs. In the meantime the community has created patches which are collected in the github projects bugtracker and pull requests. This unofficial version cherry picks the useful stuff of it. Highlights of unofficial phpvirtualbox 5.1-1: * based on git commit 65ebced (latest commit from May 19, 2016) * Patch to support Virtualbox 5.1 phpvirtualbox/phpvirtualbox#22 * Fix argument count mismatches revealed by PHP 7.1 phpvirtualbox/phpvirtualbox#24 * Make decryption of images/VMs work by not providing a password ID phpvirtualbox/phpvirtualbox#55 * Tried to make clearOnSuspend work phpvirtualbox/phpvirtualbox#57 PR: ports/220171 Submitted By: rozhuk.im With hat: vbox@ (kind of)
Contributor
|
Without running it, it looks reasonable to me. What do you mean by "doesn't seem to work"? Are you saying that the underlying OS call doesn't work as expected? |
Contributor
Author
|
I don't know where the problem actually is, that is why I provided the PR for review. "doesn't work" really only means that I'm forced to always enter the password, while according to the docs of VirtualBox that shouldn't be necessary IF my changes would be correct. So either I'm doing something wrong somewhere or yes, the argument might be ignored by VirtualBox for some reason. But I'm somewhat sure that I tested it without phpVirtualBox on the shell and that worked and I think it is more likely that I'm doing something wrong as well. |
Contributor
|
Cool. Thanks. I'll try to test this patch separately to master. :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is related to #56 and tries to make
clearOnSuspendwork, but doesn't seem to work for some reason. I've chosen the approach to provide that flag per password, because it makes implementation easier and simply seems more in line with the used API and commandline: One password, one flag.https://www.virtualbox.org/manual/ch09.html#diskencryption-startvm
https://www.virtualbox.org/sdkref/interface_i_console.html#afa62b003141e327ec7845446498ae87b