Change SCSI maxPortCount to 15 (by pasha1st)#189
Merged
h6w merged 1 commit intophpvirtualbox:developfrom Sep 8, 2019
chotaire:chot-scsi-disks
Merged
Change SCSI maxPortCount to 15 (by pasha1st)#189h6w merged 1 commit intophpvirtualbox:developfrom chotaire:chot-scsi-disks
h6w merged 1 commit intophpvirtualbox:developfrom
chotaire:chot-scsi-disks
Conversation
chotaire
changed the title
Contributor
|
Perfect! Thanks. :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request changes the SCSI maxPortCount from 16 to 15, as documented by Oracle: "Primarily for compatibility with other virtualization software, Oracle VM VirtualBox optionally supports LSI Logic and BusLogic SCSI controllers, to each of which up to 15 virtual hard disks can be attached." at https://www.virtualbox.org/manual/ch05.html
Fixed by @pasha1st - his pull request #167 got legitimately rejected due to several issues so I am lending a helping hand and split this into multiple pull requests. This needs tested and finally merged, we need to move forward.