X Tutup
Skip to content

Improvements to Check version and Vrdeaddress#124

Open
marcelojannotti wants to merge 7 commits intophpvirtualbox:developfrom
marcelojannotti:develop
Open

Improvements to Check version and Vrdeaddress#124
marcelojannotti wants to merge 7 commits intophpvirtualbox:developfrom
marcelojannotti:develop

Conversation

@marcelojannotti
Copy link

@marcelojannotti marcelojannotti commented May 4, 2018

  • backward compatibility for minor versions on same major versions
  • error message translation
  • updated project page
  • Permit empty values on vrde address to unset vrdeaddress

- Add translation;
- Allow less minor versions in the same major version;
- Updated project page;
- Removed reference to Versioning file that not existed.
- Add translate to error message from check version in chooser.js.
Permit '' to vrdeaddress. This option, give access all address. Is the same that '0.0.0.0', but more friendly.
Add information of how to set vrdeaddress to any address
@marcelojannotti marcelojannotti changed the title Improvements to Check version Improvements to Check version and Vrdeaddress Jun 5, 2018
@h6w
Copy link
Contributor

h6w commented Jun 12, 2018

Sorry. I've had to sit and think about this for awhile. Basically, you're making a policy decision in code, which is to guarantee that we will be able to support point releases where phpVBoxVer > VBoxVer. I don't think this is necessarily true. Each point release has its own endpoint/lib/vboxweb(service)-X.Y.wsdl and we currently don't load a separate one depending on the point release.

@marcelojannotti
Copy link
Author

marcelojannotti commented Jun 12, 2018

I understood. I think that the vitrualbox project when publish a new version, exemple virualbox 5.3, all files had a retrocompatibility with previous versions 5.2, 5.1 and 5.0. Then, the endpoint/lib/vboxweb(service)-5.3.wsdl should be retrocompatible too.

But, this is not a rule.

@h6w
Copy link
Contributor

h6w commented Jun 12, 2018

Yes, and although they've been largely compatible so far, there have also been unexpected changes, so we've taken to checking it each time. I had considered keeping the old wsdl files around for awhile and loading them depending on the VBox version. That would acheive the same aim. Something like if(!file_exists("endpoints/lib/vboxweb-$x.$y.wsdl") || !file_exists("endpoints/lib/vboxwebservice-$x.$y.wsdl") { ... alert ...}

The other changes are good, though. I'd also suggest using isset() for ports as well for symmetry. That way the config will become simpler.

@marcelojannotti
Copy link
Author

marcelojannotti commented Jun 12, 2018

I think that vrdeport is required and not can't be omitted. But I'll check this.

About version issue, have more than 1 version of wsdl files can be confuse, especially when has multi vbox servers.

@h6w
Copy link
Contributor

h6w commented Jun 12, 2018

We can have a default vrdeport (9000-9100) when it's omitted.

When there are multiple vbox servers you can only log into them one at a time, so we could still detect the version after logging in and verify the same way we do now.

Changed vrdeaddress default value to EMPTY (any address)
With empty default value to vrdeaddress, the ISSET() don't is necessary
@marcelojannotti
Copy link
Author

I changed the default vrdeaddress to empty, because it is the default of vbox. And has been removed the ISSET(), because is not more necessary.

The default vbox vrdeport is 3389. But, phpvirutalbox the default port actually is 3390-5000. I don't think so interesting change this value because that can be to interfere on old users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

X Tutup