Added $lazy_connect argument to RedisCluster's constructor#2753
Open
nicolas-grekas wants to merge 1 commit intophpredis:developfrom
Open
Added $lazy_connect argument to RedisCluster's constructor#2753nicolas-grekas wants to merge 1 commit intophpredis:developfrom
nicolas-grekas wants to merge 1 commit intophpredis:developfrom
Conversation
Member
|
I like this improvement but I think it's too dangerous to accept it to upcoming release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both Redis and RedisArray classes can be constructed in a way that makes them lazy-connecting to the Redis service.
This PR adds the same to RedisCluster with a new argument added to its constructor (the class has no
$optionsarray so we have to add an argument).(Would be awesome to have in 6.3!)