Open
Conversation
dantleech
force-pushed
the
incremental-updates
branch
from
b8f26b5 to
550f24e
Compare
Instead of the IDE passing the entire document each time it will now (by default?) pass only the text edits. This will reduce I/O (nobody cares) but it will also open the possibltiy of incrementally updating the AST.
dantleech
commented
Dec 29, 2025
| "phpactor/phly-event-dispatcher": "^2.2.0", | ||
| "phpactor/language-server": "^7.0.1", | ||
| "phpactor/language-server-protocol": "^3.17.4", | ||
| "phpactor/language-server": "dev-master", |
dantleech
commented
Dec 29, 2025
| return new TextDocumentHandler($container->get(EventDispatcherInterface::class)); | ||
| return new TextDocumentHandler( | ||
| $container->get(EventDispatcherInterface::class), | ||
| TextDocumentSyncKind::INCREMENTAL, |
Collaborator
Author
There was a problem hiding this comment.
make this configurable? although i'm not sure why we'd want to beyond offering an initial opt-in or fallback if it doesn't work as expected.
Contributor
There was a problem hiding this comment.
In worst case we can revert it before next release.
dantleech
force-pushed
the
incremental-updates
branch
from
550f24e to
272f32d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of the IDE passing the entire document each time it will now (by default?) pass only the text edits.
This will reduce I/O (nobody cares unless running over a slow network) but it will also open the possibltiy of incrementally updating the AST.