Conversation
Contributor
|
Yes this makes the most sense. |
Contributor
|
There's also an easier, far more ugly solution: Spawn one instance of Phpactor per workspace zobo/vscode-php-intellisense#34 Not recommending, just saying... |
Collaborator
Author
|
that's not so different from the proposed solution, just instead of a new process it's just a new instance of the container |
mamazu
reviewed
Mar 29, 2025
| override def completion( | ||
| params: CompletionParams | ||
| ): CompletableFuture[CompletionList] = | ||
| getServiceFor(params.getTextDocument.getUri).completion(params) |
Contributor
There was a problem hiding this comment.
I think the problem with this approach does not allow cross workspace completions. Which means that would be incompatible with splitting off the stubs into it's own index.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial research into "multi index" and then how we probably don't even need that.