X Tutup
Skip to content

Add Windows CI steps#2792

Open
zobo wants to merge 11 commits intophpactor:masterfrom
zobo:ci-windows
Open

Add Windows CI steps#2792
zobo wants to merge 11 commits intophpactor:masterfrom
zobo:ci-windows

Conversation

@zobo
Copy link
Contributor

@zobo zobo commented Nov 24, 2024

No description provided.

@zobo zobo force-pushed the ci-windows branch 4 times, most recently from e2ba6d5 to 60a9aa3 Compare November 24, 2024 19:09
@dantleech
Copy link
Collaborator

dantleech commented Nov 25, 2024

Looks like we'd need to track down whatever is blocking forever, but this would be great to have as a permitted failure job

@zobo
Copy link
Contributor Author

zobo commented Nov 25, 2024

Yes. It doesn't block locally. Will see what I can find.

Also, a lot of tests fail due to different line endings. I can fix some, but an easy fix would be to use a line ending independent assertEquals. How do you feel about that?

@zobo
Copy link
Contributor Author

zobo commented Dec 24, 2024

I've made it so that the windows job does not fail the workflow (as per GitHub docs). I'll wait for phpactor/test-utils#13 to be merged and then see how for we are. A lot of tests can pass if the work dir is checked out with LF instead of CRLF, but a bunch of tests just need more work... E.g.: phpstan seems to behave differently on Windows...

@zobo
Copy link
Contributor Author

zobo commented Mar 28, 2025

@dantleech rebased ... let me know what you think about this patch. I can keep updating it for now and try to fix more tests, or we can merge it as is...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

X Tutup