Open
Conversation
devnexen
reviewed
Mar 5, 2026
| current = ZSTR_LEN(string); | ||
| for (end = pstr; pos != UBRK_DONE; ) { | ||
| pos = ubrk_previous(bi); | ||
| if (pos == UBRK_DONE) { |
Member
There was a problem hiding this comment.
any chance we get a test for this case?
Contributor
Author
There was a problem hiding this comment.
No I think we don't need it.
Member
There was a problem hiding this comment.
Is it possible that due to an error condition, the loop ends early and the NUL byte will be written on a position before the end?
Contributor
Author
There was a problem hiding this comment.
Probably, There this is no early end. However, I found forget when ubrk_setUText is failure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tried fix a grapheme_strrev.
Ref: #20949 (review)
CC: @ndossche @devnexen