Fix richtext img url converting when branch name has a slash#329
Open
nyany wants to merge 1 commit intopages-cms:developmentfrom
Open
Fix richtext img url converting when branch name has a slash#329nyany wants to merge 1 commit intopages-cms:developmentfrom
nyany wants to merge 1 commit intopages-cms:developmentfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue:
the "raw.githubusercontent" url is not replaced with the config's "output" property. Happens only with slash-containing branches like
feature/onetwothreeTry to save this:
The result:
instead of url in format of
$output/$relativeUrlit'shttps://raw.github...../$relativeUrlReproduction steps:
feature/foobar). Branches likedeveloporfeature_one-123are fine.bodyfield of either a collection or a single md. It must be abodyfield. It doesn't affect the rich-text when used in a block field.Fix:
githubImage.tsalready hasencodePathfunction which seems to handle this problem.commit: 3b735b0 seems to fix some bug (but doesn't say what that is). Is there a reason why it's specifically
encodeURIComponentand not theencodePathfunction that was already there?Shouldn't
encodePathbe used everywhere ingithubImage.tsinstead ofencodeURIComponent?