Fix circular dependencies and target naming to enable CMake configuration#2
Draft
Fix circular dependencies and target naming to enable CMake configuration#2
Conversation
Co-authored-by: danregima <10253941+danregima@users.noreply.github.com>
- Fixed atomvalue -> value target name issue throughout atomspace - Removed circular dependencies between truthvalue and atomspace - Removed circular dependencies between execution and atomspace - Removed circular dependencies between clearbox and atomspace - Removed circular dependency between query-engine and atomspace - Temporarily disabled CogZero due to pkg-config monorepo integration issues - CMake configuration now progresses further but still has some cyclic dependency warnings Co-authored-by: danregima <10253941+danregima@users.noreply.github.com>
- Replaced all remaining atomvalue -> value references across the codebase - Fixed circular dependency between atombase and atomspace - Fixed circular dependency between feature_selection and moses - CMake now completes successfully with "Generating done" - Ready to proceed with system build Co-authored-by: danregima <10253941+danregima@users.noreply.github.com>
…omponents - Added nlohmann-json3-dev dependency - Fixed moses_exec build dependency ordering - Temporarily disabled components with compilation errors: - cognitive-visualization (nlohmann/json API issues) - agentic-kernels-catalog (syntax errors) - meta-cognition (missing header files) - evolutionary-optimization (dependency on meta-cognition) - Core OpenCog components ready to build - CMake configuration successful Co-authored-by: danregima <10253941+danregima@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Proceed with next steps for the project
Fix circular dependencies and target naming to enable CMake configuration
Feb 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
CMake configuration failed due to circular dependencies between atomspace components and incorrect target names throughout the codebase (
atomvaluevsvalue).Changes
Circular Dependency Resolution
Removed 7 circular dependencies by eliminating unnecessary
ADD_DEPENDENCIESdirectives where components only required link-time dependencies:atombase↔atomspace: removed atomspace from atombase dependenciestruthvalue↔atomspace: removed atomspace from truthvalue dependenciesexecution↔atomspace: removed atomspace from execution dependenciesclearbox↔atomspace: removed atomspace from clearbox dependenciesquery-engine↔atomspace: removed atomspace from query-engine dependenciesatomspaceADD_DEPENDENCIES to only core dependenciesfeature_selection↔moses: removed moses from feature_selection dependenciesTarget Name Corrections
Replaced incorrect
atomvaluetarget references withvaluein 90+ CMakeLists.txt files across:Dependency Ordering
Added explicit
ADD_DEPENDENCIES(moses_exec cogutil comboreduct moses)to prevent race conditions in parallel builds.Component Management
Temporarily disabled non-core components with compilation errors to unblock core OpenCog build:
System Dependencies
Result
CMake configuration now completes successfully. Core OpenCog components (cogutil, atomspace, cogserver, moses, ure, unify, pln, miner, asmoses, lg-atomese) are ready for build.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.