Closed
Conversation
Member
|
@bboyHan, thanks for doing this. I am about to initiate a project to clean up the codebase as this fits in just right: https://github.com/openstack4j/openstack4j/projects/1 |
| } | ||
| m.fixedIps.removeIf(fixedIP -> | ||
| fixedIP.getSubnetId() != null && | ||
| fixedIP.getSubnetId().equals(subnetId) && |
Member
There was a problem hiding this comment.
Nice catch. This can be made even simpler by using Object#equals.
| } | ||
| m.allowedAddressPairs.removeIf(allowedAddress -> | ||
| allowedAddress.getIpAddress() != null && | ||
| allowedAddress.getIpAddress().equals(ipAddress) && |
olivergondza
requested changes
Oct 30, 2020
Member
olivergondza
left a comment
olivergondza
left a comment
There was a problem hiding this comment.
I have added some review comments. The rest looks quite good. Please address those, and this can be merged.
bboyHan
commented
Oct 31, 2020
Contributor
Author
bboyHan
left a comment
bboyHan
left a comment
There was a problem hiding this comment.
Thanks for your reply!
Should I need to delete the other codes that you didn't added comments?
Member
|
@bboyHan, Parts I have not commented on are ok. Please fix what I have commented on. |
Member
|
Please resolve conflicts sothis can be merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#91 fixed it.
I have done an in-depth reading of the source code of this framework, and feel that it is well written. Therefore, I also hope to join your team to develop and extend functions. can I ？