X Tutup
Skip to content

Fix #83: Neutron: Add floatingIp port forwardings service#86

Merged
olivergondza merged 3 commits intoopenstack4j:masterfrom
aluomaidi:port_forwardings
Nov 5, 2020
Merged

Fix #83: Neutron: Add floatingIp port forwardings service#86
olivergondza merged 3 commits intoopenstack4j:masterfrom
aluomaidi:port_forwardings

Conversation

@aluomaidi
Copy link
Copy Markdown
Contributor

@aluomaidi aluomaidi commented Oct 20, 2020 •
edited by olivergondza
Loading

@olivergondza
Copy link
Copy Markdown
Member

olivergondza commented Oct 23, 2020

Thanks for your contribution, the code looks good. Please note one of the tests fails:

testList(org.openstack4j.api.network.PortForwardingTests)  Time elapsed: 0.013 sec  <<< FAILURE!
java.lang.AssertionError: expected [1] but found [2]
	at org.testng.Assert.fail(Assert.java:94)
	at org.testng.Assert.failNotEquals(Assert.java:494)
	at org.testng.Assert.assertEquals(Assert.java:123)
	at org.testng.Assert.assertEquals(Assert.java:370)
	at org.testng.Assert.assertEquals(Assert.java:380)
	at org.openstack4j.api.network.PortForwardingTests.testList(PortForwardingTests.java:66)

@olivergondza olivergondza changed the title add floatingIp port forwardings service Neutron: Add floatingIp port forwardings service Oct 23, 2020
@olivergondza olivergondza changed the title Neutron: Add floatingIp port forwardings service Fix #83: Neutron: Add floatingIp port forwardings service Oct 23, 2020
@olivergondza olivergondza merged commit 5e4495e into openstack4j:master Nov 5, 2020
@olivergondza
Copy link
Copy Markdown
Member

olivergondza commented Nov 5, 2020

Thanks for your contribution! Merging towards the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@aluomaidi @olivergondza
X Tutup