Fixed case-sensitiveness in metadata headers detection#64
Merged
olivergondza merged 1 commit intoopenstack4j:masterfrom Jul 23, 2020
Merged
Fixed case-sensitiveness in metadata headers detection#64olivergondza merged 1 commit intoopenstack4j:masterfrom
olivergondza merged 1 commit intoopenstack4j:masterfrom
Conversation
* Fixed case-sensitiveness in metadata headers detection
Member
|
Thanks! Is this the only place in the codebase with such problem, or the only one you have run into? |
Contributor
Author
|
Only place where I faced the issue while implementing the API. There might be other places - if there are, I will probably create new pull requests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am facing issue with reverse proxies forcing header names to lowercase to enforce HTTP/2.0 compliance. After referring to the RFC documentation for 1.1 (https://www.w3.org/Protocols/rfc2616/rfc2616-sec4.html#sec4.2), I realized that even at that standard, Header field names should be case-insensitive.
As a result, I forced the field name into lower-case for comparison (indexOf being case-sensitive) and added some unit tests to validate the behavior.