Octavia: Create LB pool with loadbalancerId#61
Merged
olivergondza merged 5 commits intoopenstack4j:masterfrom Jun 10, 2020
allenyinx:master
Merged
Octavia: Create LB pool with loadbalancerId#61olivergondza merged 5 commits intoopenstack4j:masterfrom allenyinx:master
olivergondza merged 5 commits intoopenstack4j:masterfrom
allenyinx:master
Conversation
…ck pool API: Either listener_id or loadbalancer_id must be specified
Author
|
@olivergondza Could you please help review the PR and merge into? Thanks, |
olivergondza
requested changes
Jun 7, 2020
Member
olivergondza
left a comment
olivergondza
left a comment
There was a problem hiding this comment.
Looks good to me except for one style remark.
core/src/main/java/org/openstack4j/model/network/ext/LbPoolV2.java
Outdated
Show resolved
Hide resolved
Author
|
@olivergondza thanks for the review. have committed the code style fix. |
olivergondza
reviewed
Jun 9, 2020
core/src/main/java/org/openstack4j/model/network/ext/builder/LbPoolV2Builder.java
Outdated
Show resolved
Hide resolved
Member
|
Thanks for you contribution. |
olivergondza
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add feature to create a pool with loadbalancerId, without a listener.
the purpose is to implement openstack pool API: Either listener_id or loadbalancer_id must be specified when creating pool.
refer to openstack API doc:
https://docs.openstack.org/api-ref/load-balancer/v2/?expanded=create-pool-detail