support DefaultPoolId update for LoadBalancer Listener#59
Merged
olivergondza merged 3 commits intoopenstack4j:masterfrom May 22, 2020
allenyinx:master
Merged
support DefaultPoolId update for LoadBalancer Listener#59olivergondza merged 3 commits intoopenstack4j:masterfrom allenyinx:master
olivergondza merged 3 commits intoopenstack4j:masterfrom
allenyinx:master
Conversation
Author
|
Hi @olivergondza can you please help review the PR? Thanks, |
core/src/main/java/org/openstack4j/openstack/networking/domain/ext/NeutronListenerV2Update.java
Outdated
Show resolved
Hide resolved
olivergondza
approved these changes
May 21, 2020
Member
olivergondza
left a comment
olivergondza
left a comment
There was a problem hiding this comment.
I have added one minor style comment.
(I appreciate the pun in the test method, what a way to make reading tests more rewarding :D)
Author
|
thanks @olivergondza for the review. could you please help merge as well? Thanks, |
Member
|
Thanks, merged! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the PR is for issue:
#57
added tests as well.