Add encryption for volume type#49
Merged
olivergondza merged 4 commits intoopenstack4j:masterfrom Apr 2, 2020
jsaroja66:encryption_volume
Merged
Add encryption for volume type#49olivergondza merged 4 commits intoopenstack4j:masterfrom jsaroja66:encryption_volume
olivergondza merged 4 commits intoopenstack4j:masterfrom
jsaroja66:encryption_volume
Conversation
olivergondza
requested changes
Mar 17, 2020
Member
olivergondza
left a comment
olivergondza
left a comment
There was a problem hiding this comment.
Thanks for you contribution! I have made some review comments, mostly on the side of style.
core/src/main/java/org/openstack4j/model/storage/block/EncryptionType.java
Outdated
Show resolved
Hide resolved
| /** | ||
| * @return the key size of the encryption type | ||
| */ | ||
| int getKeySize(); |
Member
There was a problem hiding this comment.
The docs says: "Size of encryption key, in bits. This is usually 256. The default value is None.". I believe this should be Integer with None mapped to null
Author
There was a problem hiding this comment.
I checked how size field is implemented in CinderVolume class and modified here accordingly.
It uses both Integer (json) and int (getter), I did the same.
core/src/main/java/org/openstack4j/openstack/storage/block/domain/CinderEncryptionType.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/openstack4j/model/storage/block/builder/EncryptionTypeBuilder.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/openstack4j/openstack/storage/block/domain/CinderEncryptionType.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/openstack4j/api/storage/BlockVolumeService.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/openstack4j/api/storage/BlockVolumeService.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/openstack4j/model/storage/block/EncryptionType.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/openstack4j/openstack/storage/block/internal/BlockVolumeServiceImpl.java
Show resolved
Hide resolved
olivergondza
reviewed
Apr 1, 2020
.../java/org/openstack4j/openstack/storage/block/domain/AbstractCinderVolumeTypeEncryption.java
Show resolved
Hide resolved
Member
|
@jsaroja66, thanks I have resolved all the conversations except for the |
olivergondza
approved these changes
Apr 2, 2020
Member
|
Thank you for your contribution! Merging towards the next release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.