Propagate failures from net FloatingIPService#create#29
Merged
olivergondza merged 3 commits intoopenstack4j:masterfrom Feb 21, 2020
Conversation
olivergondza
changed the title
manuelmazzuola
suggested changes
Feb 21, 2020
core/src/main/java/org/openstack4j/core/transport/HttpEntityHandler.java
Outdated
Show resolved
Hide resolved
…stack responses to exceptions
olivergondza
force-pushed
the
propagate-failures-from-NetFloatingIPService-create
branch
from
1d17a33 to
2812777
Compare
manuelmazzuola
approved these changes
Feb 21, 2020
olivergondza
deleted the
propagate-failures-from-NetFloatingIPService-create
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure the failure to assign floating IP is not silently ignored.
This also fixes #28, as without that it was not possible to verify the fix (on given connector only).