X Tutup
Skip to content

OCPBUGS-77991: suppress podman build - URLs#30851

Open
bitoku wants to merge 1 commit intoopenshift:mainfrom
bitoku:nested-container
Open

OCPBUGS-77991: suppress podman build - URLs#30851
bitoku wants to merge 1 commit intoopenshift:mainfrom
bitoku:nested-container

Conversation

@bitoku
Copy link
Contributor

@bitoku bitoku commented Mar 9, 2026 •
edited by coderabbitai bot
Loading

This PR suppresses the "podman build - URLs" test in 070-build.bats.

The whole namespace test serves as a baseline to verify Podman's core functionality within a nested container using UserNamespace and ProcMountType. However, the test is currently failing with an HTTP 429 error when trying to access github.com. This is a rate-limiting issue and is unrelated to Podman's actual functionality.

Upstream Podman has already fixed this by using localhost instead of github.com (reference). While we could update our Podman version to pull in this fix, doing so would require us to thoroughly verify whether all newly added upstream tests are compatible with our nested container setup.

We still need to figure out a more reliable and sustainable way to test this nested container functionality long-term, but as a temporary workaround, I am suppressing the failing test.

Summary by CodeRabbit

  • Tests
    • Updated test infrastructure and embedded test data for extended test scenarios.
    • Improved test suite reliability by addressing a flaky build test case.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 9, 2026

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 9, 2026
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 9, 2026

@bitoku: This pull request references Jira Issue OCPBUGS-77991, which is invalid:

  • expected the bug to target the "4.22.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This PR suppresses the "podman build - URLs" test in 070-build.bats.

The whole namespace test serves as a baseline to verify Podman's core functionality within a nested container using UserNamespace and ProcMountType. However, the test is currently failing with an HTTP 429 error when trying to access github.com. This is a rate-limiting issue and is unrelated to Podman's actual functionality.

Upstream Podman has already fixed this by using localhost instead of github.com (reference). While we could update our Podman version to pull in this fix, doing so would require us to thoroughly verify whether all newly added upstream tests are compatible with our nested container setup.

We still need to figure out a more reliable and sustainable way to test this nested container functionality long-term, but as a temporary workaround, I am suppressing the failing test.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai
Copy link

coderabbitai bot commented Mar 9, 2026 •
edited
Loading

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 568d5a9b-134c-4a35-8bb5-bc17aa7e3870

📥 Commits

Reviewing files that changed from the base of the PR and between 1ce0cb1 and fc75d66.

📒 Files selected for processing (2)
  • test/extended/testdata/bindata.go
  • test/extended/testdata/node/nested_container/skip_tests.sh

Walkthrough

The change extends an embedded asset registry with new entries and functions for asset retrieval, and marks an additional test case as skipped due to flakiness. The bindata.go additions provide an asset management system supporting hierarchical file organization, while skip_tests.sh adds a test skip entry.

Changes

Cohort / File(s) Summary
Asset Registry
test/extended/testdata/bindata.go		 Extends embedded asset infrastructure with new asset entries, hierarchical directory structure (_bintree), and retrieval functions (Asset, MustAsset, AssetInfo, AssetDir) for managing embedded files and directories.
Test Configuration
test/extended/testdata/node/nested_container/skip_tests.sh		 Adds skip entry for flaky test case "070-build.bats" with message "podman build - URLs".

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'OCPBUGS-77991: suppress podman build - URLs' directly matches the PR's main objective of suppressing the 'podman build - URLs' test.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Stable And Deterministic Test Names ✅ Passed PR contains no modifications to Ginkgo test files defining test names. Changes are limited to auto-generated asset embedding file and shell script for test skip management.
Test Structure And Quality ✅ Passed The PR modifies only bindata.go (auto-generated assets file) and skip_tests.sh (shell script), neither containing Ginkgo test code.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.5.0)

Error: can't load config: unsupported version of the configuration: "" See https://golangci-lint.run/docs/product/migration-guide for migration instructions
The command is terminated due to an error: can't load config: unsupported version of the configuration: "" See https://golangci-lint.run/docs/product/migration-guide for migration instructions

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 9, 2026
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 9, 2026

@bitoku: This pull request references Jira Issue OCPBUGS-77991, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.22.0) matches configured target version for branch (4.22.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
Details

In response to this:

This PR suppresses the "podman build - URLs" test in 070-build.bats.

The whole namespace test serves as a baseline to verify Podman's core functionality within a nested container using UserNamespace and ProcMountType. However, the test is currently failing with an HTTP 429 error when trying to access github.com. This is a rate-limiting issue and is unrelated to Podman's actual functionality.

Upstream Podman has already fixed this by using localhost instead of github.com (reference). While we could update our Podman version to pull in this fix, doing so would require us to thoroughly verify whether all newly added upstream tests are compatible with our nested container setup.

We still need to figure out a more reliable and sustainable way to test this nested container functionality long-term, but as a temporary workaround, I am suppressing the failing test.

Summary by CodeRabbit

  • Tests
  • Updated test infrastructure and embedded test data for extended test scenarios.
  • Improved test suite reliability by addressing a flaky build test case.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from deads2k and p0lyn0mial March 9, 2026 15:38
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 9, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bitoku
Once this PR has been reviewed and has the lgtm label, please assign sosiouxme for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 9, 2026

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

@bitoku
Copy link
Contributor Author

bitoku commented Mar 9, 2026

/payload-job periodic-ci-openshift-release-main-ci-4.22-e2e-gcp-ovn-usernamespace

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 9, 2026

@bitoku: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-main-ci-4.22-e2e-gcp-ovn-usernamespace

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/94c1c6a0-1bd4-11f1-931b-38917c50142d-0

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 9, 2026

@bitoku: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-ovn fc75d66 link true /test e2e-gcp-ovn
ci/prow/e2e-aws-ovn-microshift fc75d66 link true /test e2e-aws-ovn-microshift

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@p0lyn0mial p0lyn0mial Awaiting requested review from p0lyn0mial

Assignees

No one assigned

Labels

jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bitoku @openshift-ci-robot
X Tutup