X Tutup
Skip to content

NE-2131: register CIO tests extension#30847

Open
lihongan wants to merge 2 commits intoopenshift:mainfrom
lihongan:ote-for-cio
Open

NE-2131: register CIO tests extension#30847
lihongan wants to merge 2 commits intoopenshift:mainfrom
lihongan:ote-for-cio

Conversation

@lihongan
Copy link
Contributor

@lihongan lihongan commented Mar 9, 2026 •
edited
Loading

Follow up CIO: openshift/cluster-ingress-operator#1371

Summary by CodeRabbit

  • Tests
    • Added a test binary extension to expand cluster ingress operator test coverage.
    • Removed an extensive Gateway API CRD integration test suite, eliminating multiple CRD-related test cases.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 9, 2026

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 9, 2026
@openshift-ci openshift-ci bot requested review from p0lyn0mial and sjenning March 9, 2026 04:36
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 9, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: lihongan
Once this PR has been reviewed and has the lgtm label, please assign sosiouxme for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai
Copy link

coderabbitai bot commented Mar 9, 2026 •
edited
Loading

Walkthrough

Added a new test extension binary entry for the cluster-ingress-operator and removed a Ginkgo-based Gateway API CRD test suite.

Changes

Cohort / File(s) Summary
Test Extension Registry
pkg/test/extensions/binary.go		 Added a new test extension binary entry mapping imageTag: "cluster-ingress-operator" to binaryPath: "/usr/bin/cluster-ingress-operator-tests-ext.gz".
Removed Gateway API Tests
test/extended/router/gatewayapi.go		 Deleted a Ginkgo test suite that validated presence, immutability, and installation constraints for Gateway API CRDs (multiple CRD names), including helper that constructed synthetic CRD objects.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Stable And Deterministic Test Names ✅ Passed PR adds test binary registry entry and removes Gateway API test suite; no dynamic test names detected.
Test Structure And Quality ✅ Passed The PR registers a test binary extension for cluster-ingress-operator in binary.go rather than introducing new Ginkgo test implementations, so the custom test structure and quality check does not apply.
Title check ✅ Passed The title references registering CIO (cluster-ingress-operator) tests extension, which directly corresponds to the main change of adding a new test binary entry for cluster-ingress-operator in the extensionBinaries registry.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@lihongan
Copy link
Contributor Author

lihongan commented Mar 9, 2026

/retest-required

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 9, 2026

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

@openshift-trt
Copy link

openshift-trt bot commented Mar 9, 2026

Risk analysis has seen new tests most likely introduced by this PR.
Please ensure that new tests meet guidelines for naming and stability.

New tests seen in this PR at sha: 84ab88d

  • "[sig-network-edge][OTE][Jira:NE][OCPFeatureGate:GatewayAPI][Feature:Router][apigroup:gateway.networking.k8s.io] Verify Gateway API CRDs and ensure CRD of experimental group is not installed" [Total: 4, Pass: 4, Fail: 0, Flake: 0]
  • "[sig-network-edge][OTE][Jira:NE][OCPFeatureGate:GatewayAPI][Feature:Router][apigroup:gateway.networking.k8s.io] Verify Gateway API CRDs and ensure CRD of standard group can not be created" [Total: 4, Pass: 4, Fail: 0, Flake: 0]
  • "[sig-network-edge][OTE][Jira:NE][OCPFeatureGate:GatewayAPI][Feature:Router][apigroup:gateway.networking.k8s.io] Verify Gateway API CRDs and ensure existing CRDs can not be deleted" [Total: 4, Pass: 4, Fail: 0, Flake: 0]
  • "[sig-network-edge][OTE][Jira:NE][OCPFeatureGate:GatewayAPI][Feature:Router][apigroup:gateway.networking.k8s.io] Verify Gateway API CRDs and ensure existing CRDs can not be updated" [Total: 4, Pass: 4, Fail: 0, Flake: 0]
  • "[sig-network-edge][OTE][Jira:NE][OCPFeatureGate:GatewayAPI][Feature:Router][apigroup:gateway.networking.k8s.io] Verify Gateway API CRDs and ensure required CRDs should already be installed" [Total: 4, Pass: 4, Fail: 0, Flake: 0]

lihongan added 2 commits March 10, 2026 09:49
@lihongan
register CIO tests extension
04925e2
@lihongan
remove GatewayAPI CRD tests migrated to cluster-ingress-operator OTE
801c758 
Tests in test/extended/router/gatewayapi.go have been migrated to the
cluster-ingress-operator tests-extension binary. Removing them from
origin prevents duplicate test runs.
@lihongan lihongan changed the title WIP: register CIO tests extension NE-2131: register CIO tests extension Mar 10, 2026
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 10, 2026
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 10, 2026
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 10, 2026 •
edited by openshift-ci bot
Loading

@lihongan: This pull request references NE-2131 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Summary by CodeRabbit

  • Tests
  • Added a test binary extension to expand cluster ingress operator test coverage.
  • Removed an extensive Gateway API CRD integration test suite, eliminating multiple CRD-related test cases.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 10, 2026

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 10, 2026

@lihongan: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-microshift 84ab88d link true /test e2e-aws-ovn-microshift
ci/prow/e2e-metal-ipi-ovn-ipv6 84ab88d link true /test e2e-metal-ipi-ovn-ipv6

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@lihongan lihongan mentioned this pull request Mar 10, 2026
Closed
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 10, 2026 •
edited by openshift-ci bot
Loading

@lihongan: This pull request references NE-2131 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Follow up CIO: openshift/cluster-ingress-operator#1371

Summary by CodeRabbit

  • Tests
  • Added a test binary extension to expand cluster ingress operator test coverage.
  • Removed an extensive Gateway API CRD integration test suite, eliminating multiple CRD-related test cases.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@p0lyn0mial p0lyn0mial Awaiting requested review from p0lyn0mial

@sjenning sjenning Awaiting requested review from sjenning

Assignees

No one assigned

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lihongan @openshift-ci-robot
X Tutup