WIP: Fake o/o PR that bumps o/k to my branch that bumps v1.35.2#30843
Open
jubittajohn wants to merge 13 commits intoopenshift:mainfrom
Open
WIP: Fake o/o PR that bumps o/k to my branch that bumps v1.35.2#30843jubittajohn wants to merge 13 commits intoopenshift:mainfrom
jubittajohn wants to merge 13 commits intoopenshift:mainfrom
Conversation
This reverts commit 561a716.
|
Pipeline controller notification For optional jobs, comment This repository is configured in: automatic mode |
openshift-ci
bot
added
the
do-not-merge/work-in-progress
WalkthroughUpdates Go toolchain and many module dependencies; adjusts CI and linter configs and a Dockerfile base. Smaller code changes update image extraction logic, node schedulability calls, container exec types, a config shim method, test image mappings, and one test fixture image reference. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@go.mod`:
- Around line 420-451: The go.mod contains replace directives redirecting many
k8s.io modules (e.g., replace entries for k8s.io/api, k8s.io/client-go, and
k8s.io/kubernetes) to a personal fork (github.com/jubittajohn/kubernetes) with a
pseudo-version; remove those fork replace directives or, if they must remain
temporarily, add a documented merge plan and justification: update the go.mod to
restore upstream k8s.io/* modules (or add clear comments above the replace
block), open a tracked design/PR that states the reason, security/license
review, acceptance criteria, and a timeline/condition for reverting to upstream,
and ensure the k8s.io/kubernetes version is aligned (not v1.30.1-0) before
merging.
- Line 3: go.mod now targets Go 1.25.0 but CI builder images are still pinned to
golang-1.24 which will break builds; update the CI image references to use
golang-1.25: change the image tag in .ci-operator.yaml from
rhel-9-release-golang-1.24-openshift-4.22 to the corresponding
rhel-9-release-golang-1.25-openshift-4.22 and update
images/tests/Dockerfile.rhel from rhel-9-golang-1.24-openshift-4.22 to
rhel-9-golang-1.25-openshift-4.22 so the CI builder images match the go
directive in go.mod.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 5f74ed1f-64ce-4d60-a64e-94cb875afc3c
⛔ Files ignored due to path filters (299)
go.sumis excluded by!**/*.sumvendor/cyphar.com/go-pathrs/.golangci.ymlis excluded by!**/vendor/**,!vendor/**vendor/cyphar.com/go-pathrs/COPYINGis excluded by!**/vendor/**,!vendor/**vendor/cyphar.com/go-pathrs/doc.gois excluded by!**/vendor/**,!vendor/**vendor/cyphar.com/go-pathrs/handle_linux.gois excluded by!**/vendor/**,!vendor/**vendor/cyphar.com/go-pathrs/internal/fdutils/fd_linux.gois excluded by!**/vendor/**,!vendor/**vendor/cyphar.com/go-pathrs/internal/libpathrs/error_unix.gois excluded by!**/vendor/**,!vendor/**vendor/cyphar.com/go-pathrs/internal/libpathrs/libpathrs_linux.gois excluded by!**/vendor/**,!vendor/**vendor/cyphar.com/go-pathrs/procfs/procfs_linux.gois excluded by!**/vendor/**,!vendor/**vendor/cyphar.com/go-pathrs/root_linux.gois excluded by!**/vendor/**,!vendor/**vendor/cyphar.com/go-pathrs/utils_linux.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/containerd/errdefs/pkg/errhttp/http.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/containerd/ttrpc/metadata.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/containerd/ttrpc/server.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/containerd/typeurl/v2/types.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/containerd/typeurl/v2/types_gogo.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/.golangci.ymlis excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/CHANGELOG.mdis excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/COPYING.mdis excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/LICENSE.BSDis excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/LICENSE.MPL-2.0is excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/README.mdis excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/VERSIONis excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/codecov.ymlis excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/doc.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/gocompat_generics_go121.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/gocompat_generics_unsupported.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/internal/consts/consts.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/join.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/open_linux.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/openat2_linux.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/openat_linux.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/README.mdis excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/doc.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/internal/assert/assert.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/internal/errors_linux.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/internal/fd/at_linux.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/internal/fd/fd.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/internal/fd/fd_linux.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/internal/fd/mount_linux.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/internal/fd/openat2_linux.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/internal/gocompat/README.mdis excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/internal/gocompat/doc.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/internal/gocompat/gocompat_errors_go120.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/internal/gocompat/gocompat_errors_unsupported.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/internal/gocompat/gocompat_generics_go121.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/internal/gocompat/gocompat_generics_unsupported.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/internal/gopathrs/doc.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/internal/gopathrs/lookup_linux.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/internal/gopathrs/mkdir_linux.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/internal/gopathrs/open_linux.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/internal/gopathrs/openat2_linux.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/internal/kernelversion/kernel_linux.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/internal/linux/doc.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/internal/linux/mount_linux.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/internal/linux/openat2_linux.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/internal/procfs/procfs_linux.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/internal/procfs/procfs_lookup_linux.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/mkdir.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/mkdir_libpathrs.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/mkdir_purego.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/open.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/open_libpathrs.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/open_purego.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/procfs/procfs_libpathrs.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/procfs/procfs_purego.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/procfs_linux.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/vfs.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/AUTHORSis excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/common.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/swagger.yamlis excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/build/build.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/build/cache.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/build/disk_usage.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/client.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/common/id_response.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/container/commit.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/container/container.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/container/container_top.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/container/container_update.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/container/disk_usage.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/container/exec.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/container/health.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/container/hostconfig.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/container/network_settings.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/container/port.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/container/state.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/container/stats.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/container/top_response.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/container/update_response.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/filters/errors.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/filters/parse.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/image/disk_usage.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/image/image_inspect.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/image/opts.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/image/summary.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/mount/mount.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/network/endpoint.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/network/network.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/registry/authconfig.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/registry/registry.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/registry/search.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/storage/driver_data.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/swarm/config.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/swarm/node.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/swarm/secret.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/swarm/service.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/swarm/swarm.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/swarm/task.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/system/disk_usage.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/system/info.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/time/timestamp.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/types.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/types_deprecated.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/volume/disk_usage.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/build_cancel.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/build_prune.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/checkpoint.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/checkpoint_create.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/checkpoint_delete.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/checkpoint_list.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/client.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/client_interfaces.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/config_create.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/config_inspect.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/config_list.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/config_remove.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/config_update.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/container_attach.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/container_commit.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/container_copy.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/container_create.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/container_diff.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/container_exec.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/container_export.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/container_inspect.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/container_kill.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/container_list.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/container_logs.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/container_pause.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/container_prune.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/container_remove.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/container_rename.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/container_resize.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/container_restart.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/container_start.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/container_stats.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/container_stop.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/container_top.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/container_unpause.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/container_update.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/container_wait.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/disk_usage.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/distribution_inspect.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/errors.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/events.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/hijack.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/image_build.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/image_create.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/image_history.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/image_history_opts.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/image_import.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/image_inspect.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/image_inspect_opts.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/image_list.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/image_load.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/image_load_opts.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/image_prune.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/image_pull.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/image_push.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/image_remove.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/image_save.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/image_save_opts.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/image_search.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/image_tag.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/info.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/interface_stable.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/login.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/network_connect.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/network_create.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/network_disconnect.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/network_inspect.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/network_list.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/network_prune.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/network_remove.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/node_inspect.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/node_list.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/node_remove.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/node_update.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/options.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/ping.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/plugin_disable.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/plugin_enable.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/plugin_inspect.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/plugin_install.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/plugin_list.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/plugin_push.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/plugin_remove.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/plugin_set.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/plugin_upgrade.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/request.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/secret_create.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/secret_inspect.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/secret_list.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/secret_remove.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/secret_update.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/service_create.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/service_inspect.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/service_list.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/service_logs.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/service_remove.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/service_update.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/swarm_get_unlock_key.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/swarm_init.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/swarm_inspect.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/swarm_unlock.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/task_inspect.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/task_list.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/task_logs.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/utils.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/version.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/volume_create.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/volume_inspect.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/volume_list.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/volume_prune.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/volume_remove.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/volume_update.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/errdefs/defs.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/errdefs/doc.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/errdefs/helpers.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/errdefs/http_helpers.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/errdefs/is.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/internal/lazyregexp/lazyregexp.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/internal/multierror/multierror.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/pkg/archive/archive_deprecated.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/pkg/archive/changes_deprecated.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/pkg/archive/copy_deprecated.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/pkg/archive/diff_deprecated.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/pkg/archive/path_deprecated.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/pkg/archive/time_linux.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/pkg/archive/time_unsupported.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/pkg/archive/utils.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/pkg/archive/whiteouts_deprecated.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/pkg/archive/wrap_deprecated.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/pkg/idtools/idtools.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/pkg/idtools/idtools_unix.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/pkg/idtools/idtools_windows.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/pkg/idtools/usergroupadd_linux.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/pkg/idtools/usergroupadd_unsupported.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/pkg/idtools/utils_unix.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/pkg/ioutils/buffer.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/pkg/ioutils/bytespipe.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/pkg/ioutils/fswriters.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/pkg/ioutils/readers.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/pkg/ioutils/writeflusher.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/pkg/ioutils/writers.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/pkg/jsonmessage/jsonmessage.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/pkg/pools/pools.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/pkg/stdcopy/stdcopy.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/pkg/system/args_windows.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/pkg/system/chtimes.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/pkg/system/chtimes_nowindows.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/pkg/system/errors.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/pkg/system/filesys.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/pkg/system/filesys_unix.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/pkg/system/filesys_windows.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/pkg/system/init_windows.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/pkg/system/lstat_unix.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/pkg/system/lstat_windows.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/pkg/system/mknod.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/pkg/system/mknod_freebsd.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/pkg/system/mknod_unix.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/pkg/system/stat_bsd.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/pkg/system/stat_darwin.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/pkg/system/stat_illumos.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/pkg/system/stat_linux.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/pkg/system/stat_openbsd.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/pkg/system/stat_unix.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/pkg/system/stat_windows.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/pkg/system/utimes_unix.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/pkg/system/utimes_unsupported.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/pkg/system/xattrs.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/pkg/system/xattrs_linux.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/pkg/system/xattrs_unsupported.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/gogo/protobuf/sortkeys/sortkeys.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/google/cadvisor/container/common/helpers.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/google/cadvisor/container/containerd/factory.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/google/cadvisor/container/containerd/identifiers/validate.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/google/cadvisor/container/containerd/namespaces/context.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/google/cadvisor/container/containerd/pkg/dialer/dialer.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/google/cadvisor/manager/container.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/google/cadvisor/manager/manager.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/klauspost/compress/README.mdis excluded by!**/vendor/**,!vendor/**vendor/github.com/klauspost/compress/fse/bitwriter.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/klauspost/compress/fse/compress.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/klauspost/compress/huff0/bitwriter.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/klauspost/compress/huff0/compress.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/klauspost/compress/huff0/decompress.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/klauspost/compress/huff0/decompress_amd64.gois excluded by!**/vendor/**,!vendor/**
📒 Files selected for processing (1)
go.mod
Comment on lines
+420
to
451
| k8s.io/api => github.com/jubittajohn/kubernetes/staging/src/k8s.io/api v0.0.0-20260305161212-610b2b9fca22 | ||
| k8s.io/apiextensions-apiserver => github.com/jubittajohn/kubernetes/staging/src/k8s.io/apiextensions-apiserver v0.0.0-20260305161212-610b2b9fca22 | ||
| k8s.io/apimachinery => github.com/jubittajohn/kubernetes/staging/src/k8s.io/apimachinery v0.0.0-20260305161212-610b2b9fca22 | ||
| k8s.io/apiserver => github.com/jubittajohn/kubernetes/staging/src/k8s.io/apiserver v0.0.0-20260305161212-610b2b9fca22 | ||
| k8s.io/cli-runtime => github.com/jubittajohn/kubernetes/staging/src/k8s.io/cli-runtime v0.0.0-20260305161212-610b2b9fca22 | ||
| k8s.io/client-go => github.com/jubittajohn/kubernetes/staging/src/k8s.io/client-go v0.0.0-20260305161212-610b2b9fca22 | ||
| k8s.io/cloud-provider => github.com/jubittajohn/kubernetes/staging/src/k8s.io/cloud-provider v0.0.0-20260305161212-610b2b9fca22 | ||
| k8s.io/cluster-bootstrap => github.com/jubittajohn/kubernetes/staging/src/k8s.io/cluster-bootstrap v0.0.0-20260305161212-610b2b9fca22 | ||
| k8s.io/code-generator => github.com/jubittajohn/kubernetes/staging/src/k8s.io/code-generator v0.0.0-20260305161212-610b2b9fca22 | ||
| k8s.io/component-base => github.com/jubittajohn/kubernetes/staging/src/k8s.io/component-base v0.0.0-20260305161212-610b2b9fca22 | ||
| k8s.io/component-helpers => github.com/jubittajohn/kubernetes/staging/src/k8s.io/component-helpers v0.0.0-20260305161212-610b2b9fca22 | ||
| k8s.io/controller-manager => github.com/jubittajohn/kubernetes/staging/src/k8s.io/controller-manager v0.0.0-20260305161212-610b2b9fca22 | ||
| k8s.io/cri-api => github.com/jubittajohn/kubernetes/staging/src/k8s.io/cri-api v0.0.0-20260305161212-610b2b9fca22 | ||
| k8s.io/cri-client => github.com/jubittajohn/kubernetes/staging/src/k8s.io/cri-client v0.0.0-20260305161212-610b2b9fca22 | ||
| k8s.io/csi-translation-lib => github.com/jubittajohn/kubernetes/staging/src/k8s.io/csi-translation-lib v0.0.0-20260305161212-610b2b9fca22 | ||
| k8s.io/dynamic-resource-allocation => github.com/jubittajohn/kubernetes/staging/src/k8s.io/dynamic-resource-allocation v0.0.0-20260305161212-610b2b9fca22 | ||
| k8s.io/endpointslice => github.com/jubittajohn/kubernetes/staging/src/k8s.io/endpointslice v0.0.0-20260305161212-610b2b9fca22 | ||
| k8s.io/externaljwt => github.com/jubittajohn/kubernetes/staging/src/k8s.io/externaljwt v0.0.0-20260305161212-610b2b9fca22 | ||
| k8s.io/kube-aggregator => github.com/jubittajohn/kubernetes/staging/src/k8s.io/kube-aggregator v0.0.0-20260305161212-610b2b9fca22 | ||
| k8s.io/kube-controller-manager => github.com/jubittajohn/kubernetes/staging/src/k8s.io/kube-controller-manager v0.0.0-20260305161212-610b2b9fca22 | ||
| k8s.io/kube-proxy => github.com/jubittajohn/kubernetes/staging/src/k8s.io/kube-proxy v0.0.0-20260305161212-610b2b9fca22 | ||
| k8s.io/kube-scheduler => github.com/jubittajohn/kubernetes/staging/src/k8s.io/kube-scheduler v0.0.0-20260305161212-610b2b9fca22 | ||
| k8s.io/kubectl => github.com/jubittajohn/kubernetes/staging/src/k8s.io/kubectl v0.0.0-20260305161212-610b2b9fca22 | ||
| k8s.io/kubelet => github.com/jubittajohn/kubernetes/staging/src/k8s.io/kubelet v0.0.0-20260305161212-610b2b9fca22 | ||
| k8s.io/kubernetes => github.com/jubittajohn/kubernetes v1.30.1-0.20260305161212-610b2b9fca22 | ||
| k8s.io/metrics => github.com/jubittajohn/kubernetes/staging/src/k8s.io/metrics v0.0.0-20260305161212-610b2b9fca22 | ||
| k8s.io/mount-utils => github.com/jubittajohn/kubernetes/staging/src/k8s.io/mount-utils v0.0.0-20260305161212-610b2b9fca22 | ||
| k8s.io/pod-security-admission => github.com/jubittajohn/kubernetes/staging/src/k8s.io/pod-security-admission v0.0.0-20260305161212-610b2b9fca22 | ||
| k8s.io/sample-apiserver => github.com/jubittajohn/kubernetes/staging/src/k8s.io/sample-apiserver v0.0.0-20260305161212-610b2b9fca22 | ||
| k8s.io/sample-cli-plugin => github.com/jubittajohn/kubernetes/staging/src/k8s.io/sample-cli-plugin v0.0.0-20260305161212-610b2b9fca22 | ||
| k8s.io/sample-controller => github.com/jubittajohn/kubernetes/staging/src/k8s.io/sample-controller v0.0.0-20260305161212-610b2b9fca22 | ||
| ) |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
# First, verify the exact content of go.mod at lines 420-451
sed -n '420,451p' go.modRepository: openshift/origin
Length of output: 4013
🏁 Script executed:
# Check if there are any comments or context around these replace directives
sed -n '410,460p' go.modRepository: openshift/origin
Length of output: 4618
🏁 Script executed:
# Also search for any other fork-related comments in the file
rg -i 'jubittajohn|fork|temporary|wip' go.modRepository: openshift/origin
Length of output: 4011
🏁 Script executed:
# Verify the go version and full context of replace block
head -5 go.mod && echo "---" && grep -n "^replace" go.modRepository: openshift/origin
Length of output: 134
Block merge until fork replace directives are removed or justified with a documented merge plan.
Lines 420–451 redirect 32 core k8s.io/* modules to a personal fork (github.com/jubittajohn/kubernetes). This is a high supply-chain and reproducibility risk for production code. If merged to main, all users will depend on a personal fork with no documented justification or merge timeline.
Specifically:
- All 32 k8s.io modules are replaced with the fork using pseudo-version
v0.0.0-20260305161212-610b2b9fca22(identical for all) k8s.io/kubernetesuses inconsistent versioning:v1.30.1-0instead of an aligned version- No comments or markers indicate this is temporary or experimental
- No approval trail or merge plan is visible
Before merging, provide:
- Justification for the fork replacement
- Merge timeline and conditions for returning to upstream modules
- Security/license review of the fork repository
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@go.mod` around lines 420 - 451, The go.mod contains replace directives
redirecting many k8s.io modules (e.g., replace entries for k8s.io/api,
k8s.io/client-go, and k8s.io/kubernetes) to a personal fork
(github.com/jubittajohn/kubernetes) with a pseudo-version; remove those fork
replace directives or, if they must remain temporarily, add a documented merge
plan and justification: update the go.mod to restore upstream k8s.io/* modules
(or add clear comments above the replace block), open a tracked design/PR that
states the reason, security/license review, acceptance criteria, and a
timeline/condition for reverting to upstream, and ensure the k8s.io/kubernetes
version is aligned (not v1.30.1-0) before merging.
Signed-off-by: jubittajohn <jujohn@redhat.com>
jubittajohn
force-pushed
the
tmp-kube-bump
branch
from
a76e057 to
4407687
Compare
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jubittajohn The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (1)
go.mod (1)
421-451:⚠️ Potential issue | 🟠 MajorDo not merge with personal-fork
k8s.io/*replace directives still present.Line 421 to Line 451 redirect core Kubernetes modules to a personal fork/pseudo-version. This is fine for a WIP spike branch, but it’s a merge blocker for
mainunless explicitly reverted before landing.#!/bin/bash # Verify all personal-fork k8s replace directives still present in go.mod rg -n '^\s*k8s\.io\/[^\s]+\s*=>\s*github\.com\/jubittajohn\/kubernetes' go.mod🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@go.mod` around lines 421 - 451, The go.mod contains replace directives mapping k8s.io/* modules to a personal fork (entries like "k8s.io/api => github.com/jubittajohn/kubernetes/..."); remove those personal-fork replace directives from go.mod and restore the official k8s.io module requirements (or pin to the intended upstream k8s.io version), then run go mod tidy to ensure dependencies resolve; look for the replace lines referencing "github.com/jubittajohn/kubernetes" and remove or replace them with the correct upstream module/version for the corresponding k8s.io/* entries.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@images/tests/Dockerfile.rhel`:
- Line 1: The Dockerfile still contains an outdated LABEL key 'kubernetes-tests'
set to 1.34.1; update the LABEL value for 'kubernetes-tests' in the images/tests
Dockerfile to the new Kubernetes version introduced by this PR (match the bumped
version used elsewhere in the changes), keeping the same LABEL key and value
formatting, and ensure any other metadata labels referencing the Kubernetes
version are updated consistently.
---
Duplicate comments:
In `@go.mod`:
- Around line 421-451: The go.mod contains replace directives mapping k8s.io/*
modules to a personal fork (entries like "k8s.io/api =>
github.com/jubittajohn/kubernetes/..."); remove those personal-fork replace
directives from go.mod and restore the official k8s.io module requirements (or
pin to the intended upstream k8s.io version), then run go mod tidy to ensure
dependencies resolve; look for the replace lines referencing
"github.com/jubittajohn/kubernetes" and remove or replace them with the correct
upstream module/version for the corresponding k8s.io/* entries.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: d50abc20-939d-4ceb-bc27-2d6bdf6bddd9
⛔ Files ignored due to path filters (290)
go.sumis excluded by!**/*.sumtest/extended/util/image/zz_generated.txtis excluded by!**/zz_generated*vendor/cyphar.com/go-pathrs/.golangci.ymlis excluded by!**/vendor/**,!vendor/**vendor/cyphar.com/go-pathrs/COPYINGis excluded by!**/vendor/**,!vendor/**vendor/cyphar.com/go-pathrs/doc.gois excluded by!**/vendor/**,!vendor/**vendor/cyphar.com/go-pathrs/handle_linux.gois excluded by!**/vendor/**,!vendor/**vendor/cyphar.com/go-pathrs/internal/fdutils/fd_linux.gois excluded by!**/vendor/**,!vendor/**vendor/cyphar.com/go-pathrs/internal/libpathrs/error_unix.gois excluded by!**/vendor/**,!vendor/**vendor/cyphar.com/go-pathrs/internal/libpathrs/libpathrs_linux.gois excluded by!**/vendor/**,!vendor/**vendor/cyphar.com/go-pathrs/procfs/procfs_linux.gois excluded by!**/vendor/**,!vendor/**vendor/cyphar.com/go-pathrs/root_linux.gois excluded by!**/vendor/**,!vendor/**vendor/cyphar.com/go-pathrs/utils_linux.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/Masterminds/semver/v3/.gitignoreis excluded by!**/vendor/**,!vendor/**vendor/github.com/Masterminds/semver/v3/.golangci.ymlis excluded by!**/vendor/**,!vendor/**vendor/github.com/Masterminds/semver/v3/CHANGELOG.mdis excluded by!**/vendor/**,!vendor/**vendor/github.com/Masterminds/semver/v3/LICENSE.txtis excluded by!**/vendor/**,!vendor/**vendor/github.com/Masterminds/semver/v3/Makefileis excluded by!**/vendor/**,!vendor/**vendor/github.com/Masterminds/semver/v3/README.mdis excluded by!**/vendor/**,!vendor/**vendor/github.com/Masterminds/semver/v3/SECURITY.mdis excluded by!**/vendor/**,!vendor/**vendor/github.com/Masterminds/semver/v3/collection.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/Masterminds/semver/v3/constraints.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/Masterminds/semver/v3/doc.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/Masterminds/semver/v3/version.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/containerd/errdefs/pkg/errhttp/http.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/containerd/ttrpc/metadata.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/containerd/ttrpc/server.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/containerd/typeurl/v2/types.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/containerd/typeurl/v2/types_gogo.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/.golangci.ymlis excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/CHANGELOG.mdis excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/COPYING.mdis excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/LICENSE.BSDis excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/LICENSE.MPL-2.0is excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/README.mdis excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/VERSIONis excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/codecov.ymlis excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/doc.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/gocompat_generics_go121.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/gocompat_generics_unsupported.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/internal/consts/consts.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/join.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/open_linux.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/openat2_linux.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/openat_linux.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/README.mdis excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/doc.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/internal/assert/assert.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/internal/errors_linux.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/internal/fd/at_linux.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/internal/fd/fd.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/internal/fd/fd_linux.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/internal/fd/mount_linux.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/internal/fd/openat2_linux.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/internal/gocompat/README.mdis excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/internal/gocompat/doc.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/internal/gocompat/gocompat_errors_go120.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/internal/gocompat/gocompat_errors_unsupported.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/internal/gocompat/gocompat_generics_go121.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/internal/gocompat/gocompat_generics_unsupported.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/internal/gopathrs/doc.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/internal/gopathrs/lookup_linux.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/internal/gopathrs/mkdir_linux.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/internal/gopathrs/open_linux.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/internal/gopathrs/openat2_linux.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/internal/kernelversion/kernel_linux.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/internal/linux/doc.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/internal/linux/mount_linux.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/internal/linux/openat2_linux.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/internal/procfs/procfs_linux.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/internal/procfs/procfs_lookup_linux.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/mkdir.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/mkdir_libpathrs.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/mkdir_purego.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/open.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/open_libpathrs.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/open_purego.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/procfs/procfs_libpathrs.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/procfs/procfs_purego.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/procfs_linux.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/vfs.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/AUTHORSis excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/common.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/swagger.yamlis excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/blkiodev/blkio.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/build/build.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/build/cache.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/build/disk_usage.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/client.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/common/id_response.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/container/commit.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/container/config.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/container/container.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/container/container_top.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/container/container_update.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/container/disk_usage.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/container/exec.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/container/health.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/container/hostconfig.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/container/hostconfig_unix.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/container/hostconfig_windows.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/container/network_settings.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/container/port.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/container/state.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/container/stats.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/container/top_response.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/container/update_response.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/container/waitcondition.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/events/events.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/filters/errors.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/filters/filters_deprecated.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/filters/parse.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/image/disk_usage.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/image/image_history.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/image/image_inspect.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/image/opts.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/image/summary.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/mount/mount.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/network/endpoint.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/network/ipam.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/network/network.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/plugin.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/plugin_responses.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/registry/authconfig.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/registry/authenticate.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/registry/registry.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/registry/search.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/storage/driver_data.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/strslice/strslice.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/swarm/common.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/swarm/config.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/swarm/container.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/swarm/network.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/swarm/node.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/swarm/runtime.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/swarm/runtime/gen.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/swarm/runtime/plugin.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/swarm/runtime/plugin.protois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/swarm/runtime/runtime.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/swarm/secret.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/swarm/service.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/swarm/swarm.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/swarm/task.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/system/info.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/time/timestamp.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/types.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/types_deprecated.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/versions/compare.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/volume/disk_usage.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/volume/options.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/volume/volume_update.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/build_cancel.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/build_prune.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/checkpoint.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/checkpoint_create.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/checkpoint_delete.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/checkpoint_list.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/client.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/client_interfaces.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/client_unix.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/client_windows.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/config_create.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/config_inspect.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/config_list.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/config_remove.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/config_update.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/container_attach.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/container_commit.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/container_copy.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/container_create.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/container_diff.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/container_exec.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/container_export.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/container_inspect.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/container_kill.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/container_list.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/container_logs.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/container_pause.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/container_prune.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/container_remove.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/container_rename.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/container_resize.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/container_restart.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/container_start.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/container_stats.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/container_stop.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/container_top.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/container_unpause.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/container_update.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/container_wait.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/disk_usage.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/distribution_inspect.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/envvars.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/errors.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/events.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/hijack.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/image_build.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/image_create.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/image_history.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/image_history_opts.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/image_import.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/image_inspect.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/image_inspect_opts.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/image_list.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/image_load.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/image_load_opts.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/image_prune.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/image_pull.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/image_push.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/image_remove.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/image_save.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/image_save_opts.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/image_search.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/image_tag.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/info.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/interface_stable.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/login.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/network_connect.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/network_create.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/network_disconnect.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/network_inspect.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/network_list.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/network_prune.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/network_remove.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/node_inspect.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/node_list.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/node_remove.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/node_update.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/options.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/ping.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/plugin_create.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/plugin_disable.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/plugin_enable.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/plugin_inspect.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/plugin_install.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/plugin_list.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/plugin_push.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/plugin_remove.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/plugin_set.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/plugin_upgrade.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/request.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/secret_create.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/secret_inspect.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/secret_list.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/secret_remove.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/secret_update.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/service_create.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/service_inspect.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/service_list.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/service_logs.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/service_remove.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/service_update.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/swarm_get_unlock_key.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/swarm_init.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/swarm_inspect.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/swarm_join.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/swarm_leave.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/swarm_unlock.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/swarm_update.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/task_inspect.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/task_list.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/task_logs.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/utils.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/version.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/volume_create.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/volume_inspect.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/volume_list.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/volume_prune.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/volume_remove.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/volume_update.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/errdefs/defs.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/errdefs/doc.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/errdefs/helpers.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/errdefs/http_helpers.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/errdefs/is.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/internal/multierror/multierror.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/pkg/archive/archive_deprecated.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/pkg/archive/changes_deprecated.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/pkg/archive/copy_deprecated.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/pkg/archive/diff_deprecated.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/pkg/archive/path_deprecated.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/pkg/archive/time_linux.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/pkg/archive/time_unsupported.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/pkg/archive/utils.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/pkg/archive/whiteouts_deprecated.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/pkg/archive/wrap_deprecated.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/pkg/homedir/homedir_linux.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/pkg/homedir/homedir_others.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/pkg/idtools/idtools.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/pkg/idtools/idtools_unix.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/pkg/idtools/idtools_windows.gois excluded by!**/vendor/**,!vendor/**
📒 Files selected for processing (10)
.ci-operator.yaml.golangci.ymlgo.modimages/tests/Dockerfile.rhelpkg/cmd/openshift-tests/images/images_command.gopkg/e2eanalysis/e2e_analysis.gotest/extended/cli/basics.gotest/extended/util/compat_otp/container/docker_client.gotest/extended/util/configv1shim.gotest/extended/util/image/image.go
| @@ -1,4 +1,4 @@ | |||
| FROM registry.ci.openshift.org/ocp/builder:rhel-9-golang-1.24-openshift-4.22 AS builder | |||
| FROM registry.ci.openshift.org/ocp/builder:rhel-9-golang-1.25-openshift-4.22 AS builder | |||
There was a problem hiding this comment.
Update the Kubernetes version label to match the bump.
This bump is aligned with a Kubernetes upgrade objective, but the image metadata still advertises kubernetes-tests=1.34.1 (Line 23), which is now stale.
Suggested patch
- io.openshift.build.versions="kubernetes-tests=1.34.1" \
+ io.openshift.build.versions="kubernetes-tests=1.35.2" \🧰 Tools
🪛 Trivy (0.69.1)
[error] 1-1: Image user should not be 'root'
Specify at least 1 USER command in Dockerfile with non-root user as argument
Rule: DS-0002
(IaC/Dockerfile)
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@images/tests/Dockerfile.rhel` at line 1, The Dockerfile still contains an
outdated LABEL key 'kubernetes-tests' set to 1.34.1; update the LABEL value for
'kubernetes-tests' in the images/tests Dockerfile to the new Kubernetes version
introduced by this PR (match the bumped version used elsewhere in the changes),
keeping the same LABEL key and value formatting, and ensure any other metadata
labels referencing the Kubernetes version are updated consistently.
Contributor
|
@jubittajohn: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
Chores
Tests
Lint