X Tutup
Skip to content

Commit 1c04d7b

Browse files
author
Johan Brichau
authored
Merge pull request SeasideSt#123 from SeasideSt/122-Replace-ascii-encoding-for-non-binary-files-with-utf-8-encoding
Treat text files as utf8 encoded rather than ascii (in Pharo only for now)
2 parents c5af9a7 + 4ab1beb commit 1c04d7b

File tree

5 files changed

+11
-4
lines changed

5 files changed

+11
-4
lines changed

repository/Grease-Pharo70-Core.package/GRPharoPlatform.class/instance/readFileStreamOn.do.binary..st

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,4 +4,4 @@ readFileStreamOn: aString do: aBlock binary: aBoolean
44

55
^ aBoolean
66
ifTrue: [ aString asFileReference binaryReadStreamDo: aBlock ]
7-
ifFalse: [ aString asFileReference readStreamEncoded: 'ascii' do: aBlock ]
7+
ifFalse: [ aString asFileReference readStreamEncoded: 'utf-8' do: aBlock ]

repository/Grease-Pharo70-Core.package/GRPharoPlatform.class/instance/writeFileStreamOn.do.binary..st

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,4 @@ file library
22
writeFileStreamOn: aString do: aBlock binary: aBoolean
33
^ aBoolean
44
ifTrue: [ aString asFileReference binaryWriteStreamDo: aBlock ]
5-
ifFalse: [ aString asFileReference writeStreamEncoded: 'ascii' do: aBlock ]
5+
ifFalse: [ aString asFileReference writeStreamEncoded: 'utf-8' do: aBlock ]

repository/Grease-Pharo90-Core.package/GRPharoPlatform.class/instance/readFileStreamOn.do.binary..st

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,4 +3,4 @@ readFileStreamOn: aString do: aBlock binary: aBoolean
33

44
^ aBoolean
55
ifTrue: [ aString asFileReference binaryReadStreamDo: aBlock ]
6-
ifFalse: [ aString asFileReference readStreamEncoded: 'ascii' do: aBlock ]
6+
ifFalse: [ aString asFileReference readStreamEncoded: 'utf-8' do: aBlock ]

repository/Grease-Pharo90-Core.package/GRPharoPlatform.class/instance/writeFileStreamOn.do.binary..st

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,4 @@ file library
22
writeFileStreamOn: aString do: aBlock binary: aBoolean
33
^ aBoolean
44
ifTrue: [ aString asFileReference binaryWriteStreamDo: aBlock ]
5-
ifFalse: [ aString asFileReference writeStreamEncoded: 'ascii' do: [ :str | aBlock value: (ZnNewLineWriterStream on: str) ] ]
5+
ifFalse: [ aString asFileReference writeStreamEncoded: 'utf-8' do: [ :str | aBlock value: (ZnNewLineWriterStream on: str) ] ]
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
tests-filestreams
2+
testReadWriteToFileInFolderTextUTF8
3+
#('Übèrstrîñgé' '£ęλ~') do:[ :text |
4+
self
5+
writeToFile: text
6+
withFileNameDo:[ :fileName |
7+
self assert: text equals: (GRPlatform current contentsOfFile: fileName binary: false) ] ].

0 commit comments

Comments
 (0)
X Tutup