Use existing struct for additionalProperties that ref a schema#36
Merged
deepmap-marcinr merged 1 commit intooapi-codegen:masterfrom Jul 17, 2019
imjoshholloway:master
Merged
Use existing struct for additionalProperties that ref a schema#36deepmap-marcinr merged 1 commit intooapi-codegen:masterfrom imjoshholloway:master
deepmap-marcinr merged 1 commit intooapi-codegen:masterfrom
imjoshholloway:master
Conversation
Contributor
|
Thank you for fixing this, that code is tricky. |
adrianpk
pushed a commit
to foorester/oapi-codegen
that referenced
this pull request
Jan 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now, when a component is specified with
The generated code produces a map with an anonymous struct:
map[string]structwhich includes all the fields the referenced schema contains. This PR switches it so the generated code uses the named struct:map[string]SomeSchema.