fix: report formatting errors with line numbers#2117
Merged
jamietanna merged 1 commit intomainfrom Nov 1, 2025
Merged
Conversation
When formatting the resulting output, using `goimports`, we may receive an error due to generating invalid code using our templates. The output returned is fairly unhelpful, noting a line number, but requiring the users to take the broken output and then paste it into something that has a line number. This improves the output by reporting: - line numbers for the resulting Go code - a ❗ where the (first) formatting error is found
d684774 to
013459c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When formatting the resulting output, using
goimports, we mayreceive an error due to generating invalid code using our templates.
The output returned is fairly unhelpful, noting a line number, but
requiring the users to take the broken output and then paste it into
something that has a line number.
This improves the output by reporting:
I.e.