refactor(actions): common code for rename-file#2550
Closed
hinell wants to merge 1 commit intonvim-tree:masterfrom
Closed
refactor(actions): common code for rename-file#2550hinell wants to merge 1 commit intonvim-tree:masterfrom
hinell wants to merge 1 commit intonvim-tree:masterfrom
Conversation
gegoune
changed the title
Add `Input_path_editor` new class for common code Add `api.fs.rename_relative()` based on `Input_path_editor` new class Hard deprecate private `fn()` in case used directly elsewhere Replace `fn()` by `rename_*()` based on `Input_path_editor` new class
Member
|
See #2551 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
actions-fs-rename-file-demo.mov
lua/nvim-tree/actions/fs/rename-file.lua:Input_path_editor- new classfn()in case it's used elsewherefn()byrename_*()based onInput_path_editornew classrename_relative, unbound by defaultInput_path_editornew classrename-file.luaused for editing chunks of absolute path per feat(actions): git-aware cut / paste / rename fs actions #2542 (comment)prepare()/restore()path intended to be modified by user invim.ui.input(see example)Why class?
Why prototype-based class?