feat(lsp_jump_type): pass jump_type as a function#3534
Open
Blackmorse wants to merge 5 commits intonvim-telescope:masterfrom
Open
feat(lsp_jump_type): pass jump_type as a function#3534Blackmorse wants to merge 5 commits intonvim-telescope:masterfrom
Blackmorse wants to merge 5 commits intonvim-telescope:masterfrom
Conversation
Author
|
Hi @jamestrew, This is the second time I’m submitting this change, but I haven’t received any feedback yet. This feature is quite important for my workflow - I even maintain a personal fork of Telescope just to use it, and some of my own plugins depend on it. However, I believe this feature is generic enough to benefit the wider community. I’d really appreciate any feedback or suggestions on this PR. I’m more than willing to make improvements or rework it as needed. If the decision is to reject it, I’d also appreciate understanding the reasoning behind that choice. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When calling LSP-Telescope functions (
lsp_definitions,lsp_references, etc.), users may want to customize how the target buffer opens.Currently:
tab,tab drop,split,vsplit,never).This PR extends
jump_typeto also accept a function.When a function is provided, it will be executed instead of the predefined commands, giving users the same level of flexibility as in the multi-result case.
Example use case
I want to choose the exact window in which a reference is opened when navigating with
lsp_definitions.Today: I can do this with a window-picker when multiple definitions are found.
Limitation: When only one definition is found, I have no such option.
With this PR, I can achieve it like so:
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list relevant details about your configuration
Configuration:
Checklist: