BUG: f2py: fix allocatable character arrays in module data#30971
Open
HaoZeke wants to merge 1 commit intonumpy:mainfrom
Open
BUG: f2py: fix allocatable character arrays in module data#30971HaoZeke wants to merge 1 commit intonumpy:mainfrom
HaoZeke wants to merge 1 commit intonumpy:mainfrom
Conversation
HaoZeke
force-pushed
the
fix/f2py-allocatable-char-array
branch
from
7060ebe to
ce46ee2
Compare
Use get_descr_from_type_and_elsize for allocatable arrays in fortran_getattr, matching the non-allocatable path. Without this, NPY_STRING arrays get itemsize=0 which triggers ValueError. Closes numpy#21674
HaoZeke
force-pushed
the
fix/f2py-allocatable-char-array
branch
from
ce46ee2 to
34c8871
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Happily I was wrong in #21674 (comment) and this wasn't so bad.
Uses
get_descr_from_type_and_elsizefor allocatable arrays infortran_getattr, matching the non-allocatable path. Without this,NPY_STRINGarrays getitemsize=0which triggersValueError.Closes #21674