Open
Conversation
Author
|
Fixes gh-29336 too |
Author
|
If |
Author
|
@caph1993 do you intend on completing this in the spirit of the review comment?
Originally posted by @mattip in #27345 (comment) I submitted this alternative simpler PR. Can you please aprove the workflows to verify that it can be merged? |
caph1993
changed the title
Author
|
Could someone help triage this PR and suggest appropriate labels? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support for
equal_nanoption innp.uniquewhenaxis!=Nonefixes gh-23286.
fixes gh-20873.
This PR affects the
np.uniquefunction whenequal_nanis set to true and when the input is either a multi-dimensional array with given axis (not None) or a structured 1-dimensional array.Before this PR, the results of the following two expressions are the same:
This PR is an alternative to #27345 . It's simpler and does the job.