Fix range test assertion to check for NpgsqlRange<int>.Empty#6485
Merged
roji merged 1 commit intonpgsql:mainfrom Mar 11, 2026
Merged
Fix range test assertion to check for NpgsqlRange<int>.Empty#6485roji merged 1 commit intonpgsql:mainfrom
roji merged 1 commit intonpgsql:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the RangeTests.TypeConverter ignored test to assert emptiness using NpgsqlRange<int>.Empty instead of NUnit’s Is.Empty, which does not correctly represent “empty” semantics for NpgsqlRange<T>.
Changes:
- Replace
Assert.That(result, Is.Empty)withAssert.That(result, Is.EqualTo(NpgsqlRange<int>.Empty))for the type-converter “empty” range case.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed the TypeConverter test assertion to check empty range instead of using NUnit's EmptyConstraint which can't check NpgsqlRange emptiness.
It looks like this was inadvertently changed in the NUnit conversion PR #6183. This PR essentially puts it back to what it was before, just with the newer assertion syntax.
The test remains ignored, but now passes when run locally.