X Tutup
Skip to content

Add a connection string parameter to control NpgsqlException.BatchCommand#6098

Merged
vonzshik merged 2 commits intomainfrom
6042-allow-removing-batch-from-error
Oct 5, 2025
Merged

Add a connection string parameter to control NpgsqlException.BatchCommand#6098
vonzshik merged 2 commits intomainfrom
6042-allow-removing-batch-from-error

Conversation

@vonzshik
Copy link
Copy Markdown
Contributor

Closes #6042

@vonzshik vonzshik requested a review from roji as a code owner April 28, 2025 13:12
@vonzshik vonzshik force-pushed the 6042-allow-removing-batch-from-error branch from 994e1c1 to 4ed8d21 Compare September 10, 2025 11:41
Copy link
Copy Markdown
Member

@roji roji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we probably want to do a (low-impact) "breaking change" note on this.

@roji
Copy link
Copy Markdown
Member

roji commented Oct 1, 2025

One more thought: add a sentence to the xmldocs of NpgsqlException.BatchCommand to say that this is null unless the connection string is specified?

@vonzshik vonzshik requested a review from roji October 1, 2025 15:50
@vonzshik vonzshik merged commit f5ac3a8 into main Oct 5, 2025
16 checks passed
@vonzshik vonzshik deleted the 6042-allow-removing-batch-from-error branch October 5, 2025 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PostgresException BatchCommand property includes raw parameter values when Include Error Detail is disabled in connection string

2 participants

X Tutup