Add missing EFCore.PG Enum hack in non-generic MapEnum method#5627
Add missing EFCore.PG Enum hack in non-generic MapEnum method#5627roji merged 1 commit intonpgsql:mainfrom
Conversation
Previous fix appears to only have been applied to the generic MapEnum method. Looking for same behavior when using the non generic MapEnum method.
roji
left a comment
roji
left a comment
There was a problem hiding this comment.
Right, the non-generic enum mapping APIs were added in #4852, after the enum hackiness was introduced (in #5278), and didn't align with that. So this makes sense to me.
Also, I'm looking at switching to NpgsqlDataSourceBuilder as GlobalTypeMapper is obsolete. Does NpgsqlDataSourceBuilder support the EFCore.PG enum fix?
I did do some work to make EFCore.PG be compatible with NpgsqlDataSource+enums, but looking at the code, it seems like this wasn't completed 😅 One of my high priorities for 9.0 is to clean up this mess, and introduce a non-hacky way to manage enums across the Npgsql/EFCore.PG stack. I suggest sticking with the global type mapper for now, until that happens.
Previous fix appears to only have been applied to the generic MapEnum method. Looking for same behavior when using the non generic MapEnum method. (cherry picked from commit fbbb282)
|
Backported to 8.0.3 via ce51c27 |
|
Excellent, thanks @roji! |
2 participants
@roji, the previous fix #5278 appears to only have been applied to the generic MapEnum method. I'm looking for same behavior when using the non-generic MapEnum method.
Also, I'm looking at switching to
NpgsqlDataSourceBuilderasGlobalTypeMapperis obsolete. DoesNpgsqlDataSourceBuildersupport the EFCore.PG enum fix?