X Tutup
Skip to content

Hacky exposing of enum type mappings for EFCore.PG#5278

Merged
roji merged 1 commit intonpgsql:mainfrom
roji:EnumHackiness
Sep 25, 2023
Merged

Hacky exposing of enum type mappings for EFCore.PG#5278
roji merged 1 commit intonpgsql:mainfrom
roji:EnumHackiness

Conversation

@roji
Copy link
Copy Markdown
Member

@roji roji commented Sep 25, 2023

This is a 100% awful PR - it's just there to make EFCore.PG 8.0 work. We should definitely think about how we clean this up in the future.

@roji roji requested a review from NinoFloris September 25, 2023 21:20
@roji roji requested a review from vonzshik as a code owner September 25, 2023 21:20
Copy link
Copy Markdown
Contributor

@vonzshik vonzshik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Copy link
Copy Markdown
Member

@NinoFloris NinoFloris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup it sucks, approved!

@roji roji merged commit 78ee2c2 into npgsql:main Sep 25, 2023
@roji roji deleted the EnumHackiness branch September 25, 2023 21:51
@NinoFloris NinoFloris added this to the 8.0.0 milestone Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

X Tutup