X Tutup
Skip to content

EF: Fix INSERT INTO with no specified column values, by using DEFAULT VALUES. #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Emill merged 1 commit into from
Aug 5, 2014
Merged

EF: Fix INSERT INTO with no specified column values, by using DEFAULT VALUES. #310

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 18 additions & 8 deletions Npgsql.EntityFramework/SqlGenerators/VisitedExpression.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,6 +195,9 @@ public void AppendTarget(VisitedExpression target)

public void AppendColumns(IEnumerable<VisitedExpression> columns)
{
if (!columns.Any())
return;

Append("(");
bool first = true;
foreach (VisitedExpression expression in columns)
Expand All @@ -209,16 +212,23 @@ public void AppendColumns(IEnumerable<VisitedExpression> columns)

public void AppendValues(IEnumerable<VisitedExpression> columns)
{
Append(" VALUES (");
bool first = true;
foreach (VisitedExpression expression in columns)
if (columns.Any())
{
if (!first)
Append(",");
Append(expression);
first = false;
Append(" VALUES (");
bool first = true;
foreach (VisitedExpression expression in columns)
{
if (!first)
Append(",");
Append(expression);
first = false;
}
Append(")");
}
else
{
Append(" DEFAULT VALUES");
}
Append(")");
}

internal void AppendReturning(DbNewInstanceExpression expression)
Expand Down
8 changes: 8 additions & 0 deletions tests/EntityFrameworkBasicTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,11 @@ public class Post
public virtual Blog Blog { get; set; }
}

public class NoColumnsEntity
{
public int Id { get; set; }
}

public class BloggingContext : DbContext
{
public BloggingContext(string connection)
Expand All @@ -88,6 +93,7 @@ public BloggingContext(string connection)

public DbSet<Blog> Blogs { get; set; }
public DbSet<Post> Posts { get; set; }
public DbSet<NoColumnsEntity> NoColumnsEntities { get; set; }
}

[Test]
Expand All @@ -108,6 +114,7 @@ public void InsertAndSelect()
Title = "Some post Title " + i
});
context.Blogs.Add(blog);
context.NoColumnsEntities.Add(new NoColumnsEntity());
context.SaveChanges();
}

Expand All @@ -120,6 +127,7 @@ public void InsertAndSelect()
{
StringAssert.StartsWith("Some post Title ", post.Title);
}
Assert.AreEqual(1, context.NoColumnsEntities.Count());
}
}

Expand Down
X Tutup