X Tutup
Skip to content

EF: Fix INSERT INTO with no specified column values, by using DEFAULT VALUES.#310

Merged
Emill merged 1 commit intonpgsql:masterfrom
Emill:master
Aug 5, 2014
Merged

EF: Fix INSERT INTO with no specified column values, by using DEFAULT VALUES.#310
Emill merged 1 commit intonpgsql:masterfrom
Emill:master

Conversation

@Emill
Copy link
Copy Markdown
Contributor

@Emill Emill commented Aug 5, 2014

Fixes #233.

Instead of running

INSERT INTO "dbo"."Test"() VALUES () RETURNING "Id"

which results in parse error, run this instead:

INSERT INTO "dbo"."Test" DEFAULT VALUES RETURNING "Id"

which corresponds to the syntax at http://www.postgresql.org/docs/9.3/static/sql-insert.html.

@Emill
Copy link
Copy Markdown
Contributor Author

Emill commented Aug 5, 2014

This fix should be included in 2.2.

Emill added a commit that referenced this pull request Aug 5, 2014
@Emill
Merge pull request #310 from Emill/master
580731d 
EF: Fix INSERT INTO with no specified column values, by using DEFAULT VALUES.
@Emill Emill merged commit 580731d into npgsql:master Aug 5, 2014
@franciscojunior
Copy link
Copy Markdown
Member

franciscojunior commented Aug 5, 2014

Em 05/08/2014 19:55, "Emill" notifications@github.com escreveu:

This fix should be included in 2.2.

I'm on it!

—
Reply to this email directly or view it on GitHub.

@Emill Emill added bug labels Aug 5, 2014
@Emill Emill added this to the 2.2 milestone Aug 5, 2014
Emill added a commit that referenced this pull request Aug 6, 2014
@Emill @franciscojunior
EF: Fix INSERT INTO with no specified column values, by using DEFAULT…
1c6e2d2 
… VALUES.

(cherry picked from commit e6c6bf6)

Backport #310 from master
@franciscojunior
Copy link
Copy Markdown
Member

franciscojunior commented Aug 6, 2014

This fix should be included in 2.2.

Done.

@roji
Copy link
Copy Markdown
Member

roji commented Aug 6, 2014

@franciscojunior, we have confirmation from the user that the fix is good. I think we can release 2.2 with this even if we don't do another rc...

@franciscojunior
Copy link
Copy Markdown
Member

franciscojunior commented Aug 6, 2014

@franciscojunior, we have confirmation from the user that the fix is good. I think we can release 2.2 with this even if we don't do another rc...

Sure!
+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.2.0

Development

Successfully merging this pull request may close these issues.

3 participants

@Emill @franciscojunior @roji
X Tutup