X Tutup
Skip to content

Fix missing Association/AssociationSet(aka FK constraints) in the EF manifest files#119

Closed
kenjiuno wants to merge 2 commits intonpgsql:masterfrom
kenjiuno:ef6_patch_2_schema
Closed

Fix missing Association/AssociationSet(aka FK constraints) in the EF manifest files#119
kenjiuno wants to merge 2 commits intonpgsql:masterfrom
kenjiuno:ef6_patch_2_schema

Conversation

@kenjiuno
Copy link
Copy Markdown
Contributor

@kenjiuno kenjiuno commented Dec 9, 2013

This is updated PR from #100, targeting new 2.1.0 branch.

It adds missing relationships between entities, into the EntityFramework provider manifest.

New AssociationSets in ssdl (table to table?):

  • PgTables ⇔ PgTableColumns
  • PgTables ⇔ PgConstraints
  • PgTableColumns ⇔ PgForeignKeyColumns
  • PgConstraints ⇔ PgConstraintColumns
  • PgConstraints ⇔ PgForeignKeyColumns
  • PgViews ⇔ PgViewColumns
  • PgViews ⇔ PgViewConstraints
  • PgViewColumns ⇔ PgViewForeignKeyColumns
  • PgViewConstraints ⇔ PgViewConstraintColumns
  • PgViewConstraints ⇔ PgViewForignKeyColumns
  • PgFunctions ⇔ PgFunctionParametetrs
  • PgProcedures ⇔ PgProcedureParameters

New Associations in ssdl (column to column?):

  • ViewColumn → ViewForeignKeyColumn
  • View → ViewConstraint
  • ViewColumn → ViewForeignKeyColumn
  • ViewConstraint → ViewConstraintColumn
  • ViewConstraint → ViewForeignKeyColumn
  • Procedure → ProcedureParameter

I have figured current status to check missing ones.
https://dl.dropboxusercontent.com/u/24560712/ef6/fixed_npgsql_msl_ssdl.png

Currently EdmGen fails to generate correct schema for target database, because associations are missing. e.g. Table has no TableColumns.

@franciscojunior
Copy link
Copy Markdown
Member

franciscojunior commented Dec 10, 2013

Hi, Kenji!

Do you think those changes have any impact in the database creation support added by #91 ?

@franciscojunior franciscojunior mentioned this pull request Dec 10, 2013
Merged
@kenjiuno
Copy link
Copy Markdown
Contributor Author

kenjiuno commented Dec 10, 2013

Hi.

I think my changes to provider manifest won't affect #91.

I can test if #91 affect my changes. I'll check later, and report then.

@franciscojunior
Copy link
Copy Markdown
Member

franciscojunior commented Dec 10, 2013

Hi.

I think my changes to provider manifest won't affect #91.

I can test if #91 affect my changes. I'll check later, and report then.

Thanks for having a look at this, Kenji!

@kenjiuno
Copy link
Copy Markdown
Contributor Author

kenjiuno commented May 11, 2014

Hi.

I have added a test TestSchemaInformation to check the usability of EntityFramework provider manifest.

The SchemaInformation is to see reverse engineered objects from db, such as tables/constraints/functions/etc.

The test just checks object's existance generated by TestFixtureSetup.

@kenjiuno kenjiuno mentioned this pull request Jun 19, 2014
Merged
@roji
Copy link
Copy Markdown
Member

roji commented Jul 28, 2014

@franciscojunior and @kenjiuno, this PR is marked as open and scheduled for 2.2, are we waiting for anything on this? Or has it been superceded by #213?

@franciscojunior
Copy link
Copy Markdown
Member

franciscojunior commented Jul 28, 2014

I also don't know if it has been superceded by #213.

@kenjiuno
Copy link
Copy Markdown
Contributor Author

kenjiuno commented Jul 29, 2014

Hi.

This pr is not related with ddex working.

It fixes some missing relations.

As a result, tools like EdmGen can discover functions and stored procedures and so on.

@roji
Copy link
Copy Markdown
Member

roji commented Jul 29, 2014

OK, thanks @kenjiuno! Do you still need work on this, is it waiting review, or can it be merged? Is it tested/safe enough for inclusion in 2.2?

@kenjiuno
Copy link
Copy Markdown
Contributor Author

kenjiuno commented Jul 29, 2014

Hi.

I have no plan to improve this for now. It is completed. And it needs review. However I think anyone may not need it. So, no one can review it... I will wait for comments from someone.

EF6 and Npgsql will work well without this pr. So, please skip this pr in 2.2.

@roji roji modified the milestones: 2.2, 2.3 Jul 29, 2014
@roji roji force-pushed the master branch 2 times, most recently from 0b35ef0 to c43b6af Compare September 16, 2014 08:50
@roji roji force-pushed the master branch 2 times, most recently from e1d8c57 to 1f140e5 Compare January 14, 2015 02:37
@roji roji modified the milestones: 3.0, 3.0-beta1 Mar 30, 2015
@roji roji force-pushed the master branch 2 times, most recently from 1236d1f to e8ae2e0 Compare April 12, 2015 07:50
@roji roji force-pushed the master branch 4 times, most recently from 19a99a1 to 2fc8944 Compare April 29, 2015 14:46
@roji roji force-pushed the master branch 2 times, most recently from 33651f5 to e880d97 Compare May 2, 2015 06:55
@roji roji modified the milestones: 3.0-beta1, 3.1 Jun 26, 2015
@kenjiuno
Copy link
Copy Markdown
Contributor Author

kenjiuno commented Jun 30, 2015

I will close this pr for a moment.

@kenjiuno kenjiuno closed this Jun 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.1.0

Development

Successfully merging this pull request may close these issues.

3 participants

@kenjiuno @franciscojunior @roji
X Tutup