Open
Conversation
Links are more semantically-correct than spans. Anchor tags have native tabindex. Edit css to work with anchor tags rather than spans.
Add 'keypress' event to navigation for keyboard accessibility. Use 'on' to attach event handlers. Make navigation elements visible on hover, focus and active states.
Insert gallery navigation at start of featherlight-content rather than end. User will then tab to 'next' element first, then 'previous', then 'close'.
Collaborator
|
Thanks for the PR and wanting to improve Featherlight. I'm afraid I can't merge this as is though. First, it's not clear to me why you'd want this; aren't left and right arrow keys more intuitive and convenient? Second, changing Finally, it is not acceptable to rely on the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch was started from release 1.7.13.
Adds keyboard accessibility to the gallery navigation.