feat(git-node): refactor metadata generation#1036
Merged
aduh95 merged 3 commits intonodejs:mainfrom Mar 24, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1036 +/- ##
==========================================
- Coverage 80.94% 80.62% -0.33%
==========================================
Files 39 39
Lines 4829 4821 -8
==========================================
- Hits 3909 3887 -22
- Misses 920 934 +14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
marco-ippolito
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes Node.js contributors add a
PR-URLto their commit message (e.g. because the commit is cherry-picked from a different PR), and NCU may end up generating a commit referencing multiplePR-URLs. It's not ideal, in nodejs/core-validate-commit#125 I've explored the idea of making the CI fail on those, but it seems easier to have NCU ignore the user provided trailers when it's going to add the correct ones anyway.A consequence of that is that commits backported with a manual PR would now list the reviewers of the backport PR rather than the original PR, which seems more logical to me anyway.