fix(git-node): remove duplicated code in prepare_release.js#1047
Merged
aduh95 merged 1 commit intonodejs:mainfrom Mar 27, 2026
Merged
fix(git-node): remove duplicated code in prepare_release.js#1047aduh95 merged 1 commit intonodejs:mainfrom
prepare_release.js#1047aduh95 merged 1 commit intonodejs:mainfrom
Conversation
Security releases preparation follow the same steps as regular releases, having duplicated steps is only cumbersome AFAICT.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1047 +/- ##
=======================================
Coverage 80.93% 80.93%
=======================================
Files 39 39
Lines 4841 4841
=======================================
Hits 3918 3918
Misses 923 923 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
RafaelGSS
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As I was working on security release, I noticed the
--release-dateflag was ignored. I figured, rather than trying to fix all the flags, it'd be better to remove the duplication and re-use the well tested regular release path.Security releases preparation follow the same steps as regular releases, having duplicated steps is only cumbersome AFAICT.