module: emit experimental warning for module.register()#62518
Open
GeoffreyBooth wants to merge 1 commit intonodejs:mainfrom
Open
module: emit experimental warning for module.register()#62518GeoffreyBooth wants to merge 1 commit intonodejs:mainfrom
module.register()#62518GeoffreyBooth wants to merge 1 commit intonodejs:mainfrom
Conversation
GeoffreyBooth
added
module
Collaborator
|
Review requested:
|
nodejs-github-bot
added
esm
GeoffreyBooth
force-pushed
the
module-register-experimental-warning
branch
from
33a7c62 to
214b8e0
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #62518 +/- ##
==========================================
- Coverage 89.70% 89.70% -0.01%
==========================================
Files 692 694 +2
Lines 214039 214228 +189
Branches 41064 41113 +49
==========================================
+ Hits 192010 192178 +168
- Misses 14091 14112 +21
Partials 7938 7938
🚀 New features to boost your workflow:
|
GeoffreyBooth
force-pushed
the
module-register-experimental-warning
branch
from
214b8e0 to
792a8bf
Compare
aduh95
reviewed
Mar 31, 2026
Comment on lines
+182
to
185
| - version: REPLACEME | ||
| pr-url: https://github.com/nodejs/node/pull/62518 | ||
| description: Runtime experimental warning added. | ||
| - version: |
Contributor
There was a problem hiding this comment.
Can you change its status from 1.1 - Active development to 1 - Experimental or 1.0 - Early development?
Suggested change
| - version: REPLACEME | |
| pr-url: https://github.com/nodejs/node/pull/62518 | |
| description: Runtime experimental warning added. | |
| - version: | |
| - version: REPLACEME | |
| pr-url: https://github.com/nodejs/node/pull/62518 | |
| description: The feature is no longer in active development, a warning is emitted when used at runtime. | |
| - version: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative to #62401. Adds an experimental warning to
module.register(), without deprecating it.