meta: require DCO signoff in commit message guidelines#62510
Open
jasnell wants to merge 2 commits intonodejs:mainfrom
Open
meta: require DCO signoff in commit message guidelines#62510jasnell wants to merge 2 commits intonodejs:mainfrom
jasnell wants to merge 2 commits intonodejs:mainfrom
Conversation
Collaborator
|
Review requested:
|
aduh95
reviewed
Mar 30, 2026
jasnell
commented
Mar 30, 2026
aduh95
approved these changes
Mar 30, 2026
Contributor
aduh95
left a comment
aduh95
left a comment
There was a problem hiding this comment.
I don't know about the multiple author rules, sometimes PRs get abandoned and picked up by someone else, this imply we have no choice but to not attribute the work to the original author – but if "should" means "it is recommended", I guess it's fine
Member
Author
|
That actually gets a bit tricky. If I start work, then abandon it, and you pick it up later... My part of the contribution is still mine and I should sign off on it. I should have signed off from the start. |
Member
Author
|
@nodejs/tsc |
Member
Author
|
Assuming we move forward with this requirement, we should pin an issue in the tracker for a bit calling it out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: nodejs/core-validate-commit#141