meta: expand memory leak DoS criteria to all DoS#62505
Open
joyeecheung wants to merge 1 commit intonodejs:mainfrom
Open
meta: expand memory leak DoS criteria to all DoS#62505joyeecheung wants to merge 1 commit intonodejs:mainfrom
joyeecheung wants to merge 1 commit intonodejs:mainfrom
Conversation
We have dedicated requirements about memory leaks when triaging DoS. These applies in generall to all types of DoS, and many recent reports about DoS attack vectors fail to meet them, resulting in a lot of extra back-and-forth in triaging. Clarify in the threat model by expanding these requirements to all DoS. Drive-by: clarify criteria of documented JavaScript behavior is that they are included in ECMA262. Also use "Node.js application developer" instead of "user" the refer to the party being vulnerable to avoid confusion.
Collaborator
|
Review requested:
|
RafaelGSS
approved these changes
Mar 30, 2026
BethGriggs
approved these changes
Mar 30, 2026
aduh95
added
author ready
jasnell
reviewed
Mar 30, 2026
|
|
||
| For a behavior to be considered a DoS vulnerability, the PoC must meet the following criteria: | ||
|
|
||
| * The API is being correctly used. |
Member
There was a problem hiding this comment.
nit: this is one that's bothered me... if the API allows it to be incorrectly used and a vulnerability is found, then that's a problem. But that's not new here ;-)
Member
Author
There was a problem hiding this comment.
I can't find the link anymore but recently there was a report that use export conditions as some sort of access control list and claim that the path normalization is an attack vector. I think that's the kind of "very creative use at your own risk" this would help clarify.
jasnell
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have dedicated requirements about memory leaks when triaging DoS. These applies in generall to all types of DoS, and many recent reports about DoS attack vectors fail to meet them, resulting in a lot of extra back-and-forth in triaging. Clarify in the threat model by expanding these requirements to all DoS.
Drive-by: clarify criteria of documented JavaScript behavior is that they are included in ECMA262. Also use "Node.js application developer" instead of "user" the refer to the party being vulnerable to avoid confusion.